Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin, to see what happens #531

Merged
merged 6 commits into from
Feb 26, 2025
Merged

Unpin, to see what happens #531

merged 6 commits into from
Feb 26, 2025

Conversation

aulemahal
Copy link
Collaborator

@aulemahal aulemahal commented Feb 13, 2025

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Unpin xarray, dask and zarr to see what happens.
  • Change "<" pin of xESMF to "=!" as the bug is resolved in xESMF's master.

Does this PR introduce a breaking change?

Other information:

@Zeitsperre
Copy link
Contributor

@aulemahal Except for the rechunk error, it looks like everything is working well. Would you want to re-pin rechunker here or wait for the next rechunker release with your bug fixes?

@aulemahal
Copy link
Collaborator Author

The rechunker bug is from two incompatibilities with dask 2024.11 and xarray 2024.10. There are no rechunker versions that work with those two! But, we could fix the issue with xarray here directly. The one with dask is only fixable within rechunker and a PR is opened and ready to review there.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the docs label Feb 25, 2025
@aulemahal
Copy link
Collaborator Author

So, this :

  • does not unpin zarr < 3, which is incompatible as seen in the tests of ed7c891
  • unpins xarray as I was able to fix the rechunker issue in our rechunk method
  • does not unpin dask as the rechunker issue is unavoidable
  • allows python 3.13

@aulemahal aulemahal requested a review from Zeitsperre February 25, 2025 21:07
Copy link
Contributor

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aulemahal aulemahal merged commit 69c42f6 into main Feb 26, 2025
16 checks passed
@aulemahal aulemahal deleted the rm-pins branch February 26, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants