Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project Catalog optional check_valid, drop_duplicates #536

Merged
merged 4 commits into from
Feb 26, 2025
Merged

Project Catalog optional check_valid, drop_duplicates #536

merged 4 commits into from
Feb 26, 2025

Conversation

SarahG-579462
Copy link
Contributor

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Does this PR introduce a breaking change?

  • No

Other information:

RondeauG
RondeauG approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SarahG-579462 SarahG-579462 merged commit 7d47d9e into main Feb 26, 2025
16 checks passed
@SarahG-579462 SarahG-579462 deleted the pcat_options_optional branch February 26, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project Catalogs should allow check_valid and drop_duplicates = False
3 participants
@SarahG-579462 @RondeauG @aulemahal