cleanup(client): Clean up Go VPN APIs #2480
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyyi1
reviewed
Apr 22, 2025
| "failed to connect the tunnel"); | ||
| } | ||
| startForegroundWithNotification(config.name); | ||
| storeActiveTunnel(config, remoteUdpForwardingEnabled); |
Contributor
There was a problem hiding this comment.
This is where we store the UDP connectivity state for resuming a connection. Do we need to store it somewhere in the new arch?
Collaborator
Author
There was a problem hiding this comment.
I was thinking we should check it again. I don't think it makes sense to save this, since we check on network changes.
| // the connection due to a network error, as network may not be ready. | ||
| final TCPAndUDPConnectivityResult connResult = checkServerConnectivity(client); | ||
| if (connResult.getTCPError() != null) { | ||
| deviceConnError = remoteDevice.HasConnectivity(); |
Contributor
There was a problem hiding this comment.
Probably TestConnectivity would be a better name. HasConnectivity sounds like it will return a bool instead of an Error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a full PR at this point, but I wanted to record how this API could look like on Android and iOS.