Skip to content

Conversation

@ohnorobo
Copy link
Contributor

@ohnorobo ohnorobo commented Dec 15, 2025

Fixes #2678

npm run action client/src/cordova/build android

./check_elf_alignment.sh client/platforms/android/app/build/outputs/apk/debug/app-debug.apk

Recursively analyzing client/platforms/android/app/build/outputs/apk/debug/app-debug.apk

NOTICE: Zip alignment check requires build-tools version 35.0.0-rc3 or higher.
  You can install the latest build-tools by running the below command
  and updating your $PATH:

    sdkmanager "build-tools;35.0.0-rc3"

=== ELF alignment ===
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.TImxbQLQjD/lib/armeabi-v7a/libsentry.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.TImxbQLQjD/lib/armeabi-v7a/libgojni.so: \e[31mUNALIGNED\e[0m (2**12)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.TImxbQLQjD/lib/armeabi-v7a/libsentry-android.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.TImxbQLQjD/lib/x86/libsentry.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.TImxbQLQjD/lib/x86/libgojni.so: \e[31mUNALIGNED\e[0m (2**12)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.TImxbQLQjD/lib/x86/libsentry-android.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.TImxbQLQjD/lib/arm64-v8a/libsentry.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.TImxbQLQjD/lib/arm64-v8a/libgojni.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.TImxbQLQjD/lib/arm64-v8a/libsentry-android.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.TImxbQLQjD/lib/x86_64/libsentry.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.TImxbQLQjD/lib/x86_64/libgojni.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.TImxbQLQjD/lib/x86_64/libsentry-android.so: \e[32mALIGNED\e[0m (2**14)
\e[31mFound 2 unaligned libs (only arm64-v8a/x86_64 libs need to be aligned).\e[0m
=====================

Specifically

./check_elf_alignment.sh client/platforms/android/app/build/outputs/apk/debug/app-debug.apk | grep -e arm64-v8a -e x86_64
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.WWKTLXlorB/lib/arm64-v8a/libsentry.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.WWKTLXlorB/lib/arm64-v8a/libgojni.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.WWKTLXlorB/lib/arm64-v8a/libsentry-android.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.WWKTLXlorB/lib/x86_64/libsentry.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.WWKTLXlorB/lib/x86_64/libgojni.so: \e[32mALIGNED\e[0m (2**14)
/var/folders/_s/1987wtss17b34gz5sv0f3mfm007mzb/T/app-debug_out_XXXXX.WWKTLXlorB/lib/x86_64/libsentry-android.so: \e[32mALIGNED\e[0m (2**14)
\e[31mFound 2 unaligned libs (only arm64-v8a/x86_64 libs need to be aligned).\e[0m

TESTED: installed/launched in android emulator API 36

@ohnorobo ohnorobo marked this pull request as ready for review December 15, 2025 11:49
@ohnorobo ohnorobo requested a review from a team as a code owner December 15, 2025 11:49
@ohnorobo ohnorobo requested a review from fortuna December 15, 2025 11:49
@ohnorobo ohnorobo enabled auto-merge (squash) December 15, 2025 11:55
Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let's make sure we are seeing the reports going through before we release, since we jumped 6 major versions.

@ohnorobo ohnorobo merged commit c5360c6 into master Dec 15, 2025
30 checks passed
@ohnorobo ohnorobo deleted the android-align branch December 15, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support 16KB memory page sizes on android

3 participants