Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger: Fix some theming issues #12453

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chaoticgd
Copy link
Contributor

@chaoticgd chaoticgd commented Mar 23, 2025

Description of Changes

The PR addresses the following theming issues:

  • The layout switcher tabs appearing in the wrong place for the Windows Vista and Windows 11 styles.
  • A weird underline appearing under the non-selected tabs when using the Fusion style on Windows.
  • The background colour of the menu bar being wrong when using the Windows Vista style.
  • The bottom border of menu bar items being drawn too high.
  • The lock/unlock toggle having white on white text when the Windows 11 style is used.
  • The KDDockWidgets tab bars not updating when the style changes.

In addition, the custom menu bar has been extracted into its own class and a highlight has been added to the current tab when the Fusion style is used.

This does not fix the position of the layout switcher when using the native macOS theme. I don't have a Mac, so I can't really play with it properly.

This should be merged after #12447 so I can rebase it and update the VS filters file. Done.

Screenshots:

Screenshot_20250325_192846
Screenshot_20250325_192859
Screenshot_20250325_192918
Screenshot_20250325_192930
Screenshot_20250325_192953
Screenshot_20250325_193011

Rationale behind Changes

Fix visual bugs introduced by my docking PR.

Suggested Testing Steps

Try all the different themes on Windows and Linux.

@chaoticgd chaoticgd force-pushed the debugger_menu branch 2 times, most recently from ba895ea to 139eca8 Compare March 25, 2025 03:37
@chaoticgd chaoticgd marked this pull request as ready for review March 25, 2025 03:45
@chaoticgd chaoticgd force-pushed the debugger_menu branch 2 times, most recently from 835ff2c to 34d26eb Compare March 25, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant