Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Move Skip Presenting Duplicate Frames #12460

Merged
merged 4 commits into from
Apr 6, 2025

Conversation

JordanTheToaster
Copy link
Member

@JordanTheToaster JordanTheToaster commented Mar 26, 2025

Description of Changes

Moves Skip Presenting Duplicate Frames from Graphics Settings Advanced to Emulation Settings Frame Pacing/Latency Control,

Rationale behind Changes

Move skip dupe frames.

Suggested Testing Steps

Make sure skip duplicate frames still functions.

Copy link
Contributor

@kamfretoz kamfretoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skip duplicates are now enabled by default on new install.

image

@AmyRoxwell
Copy link

Can confirm the frame times are now being reported correctly. Before it was a mess of going 30 to 28 to 31 on the game fps counter

Master:
image

image

Pr:

image

image

@bigol83
Copy link

bigol83 commented Mar 27, 2025

GTA San Andreas and Bully frametime doubles from 20ms average to 40 ms average with this enabled by default

Enabled
Immagine 2025-03-27 232140

Disabled
Immagine 2025-03-27 232402

@JordanTheToaster
Copy link
Member Author

GTA San Andreas and Bully frametime doubles from 20ms average to 40 ms average with this enabled by default

That's intentional you are seeing the frame times without the duplicate frames.

Copy link
Contributor

@kamfretoz kamfretoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

Screenshot_20250403_185253

@Jakey757
Copy link
Contributor

Jakey757 commented Apr 3, 2025

Skip presenting duplicate frames can affect some deinterlacing modes in 30 fps games or games with mixed framerates. Bob for example will no longer do anything in 30 fps. I don't know the ramifications of this if any at all, I just thought it was worth mentioning that at least some of the deinterlacers seem to rely on the duplicated framerate to function.

@JordanTheToaster JordanTheToaster changed the title UI: Move and enable by default Skip Presenting Duplicate Frames UI: Move Skip Presenting Duplicate Frames Apr 4, 2025
@lightningterror lightningterror merged commit 7de5066 into PCSX2:master Apr 6, 2025
12 checks passed
@JordanTheToaster JordanTheToaster deleted the skippy branch April 6, 2025 17:08
Hancock33 added a commit to Hancock33/batocera.piboy that referenced this pull request Apr 6, 2025
-----------------------------------------------------------------------------------------------
lindbergh-loader.mk a68dcbbdcfb4dc58480041e907c78648fc446089 # Version: Commits on Apr 06, 2025
-----------------------------------------------------------------------------------------------
Merge pull request #88 from dkeruza-neo/master

Resolution patches for 2Spicy and HOD-Ex,

----------------------------------------------------
pcsx2.mk v2.3.259 # Version: Commits on Apr 06, 2025
----------------------------------------------------
- [UI: Move Skip Presenting Duplicate Frames](PCSX2/pcsx2#12460)

------------------------------------------------------------------------------------
rpcs3.mk b3bbd939e3604eb9a259fc829270c4f0c3856f9d # Version: Commits on Apr 06, 2025
------------------------------------------------------------------------------------
appimage: Do not bundle libQt6OpenGL,

-------------------------------------------------------------------------------------------
jazz2-native.mk 92ff7f5ca39085c10624fb3036bd4a726b026610 # Version: Commits on Apr 06, 2025
-------------------------------------------------------------------------------------------
Fixed build,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants