Skip to content

Fix parameter scale in sample_from_prior #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2025

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented May 7, 2025

Return sampled parameters on the parameter scale.
This broke in #329 & #335.

Return sampled parameters on the parameter scale.
This broke in PEtab-dev#329 & PEtab-dev#335.
@dweindl dweindl requested a review from PaulJonasJost May 7, 2025 10:05
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.00%. Comparing base (0e90fd9) to head (ab44d47).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
petab/v1/sampling.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #385   +/-   ##
========================================
  Coverage    74.00%   74.00%           
========================================
  Files           58       58           
  Lines         6470     6470           
  Branches      1115     1115           
========================================
  Hits          4788     4788           
  Misses        1260     1260           
  Partials       422      422           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@PaulJonasJost PaulJonasJost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@dweindl dweindl marked this pull request as ready for review May 8, 2025 05:59
@dweindl dweindl requested a review from a team as a code owner May 8, 2025 05:59
@dweindl dweindl merged commit 3bc6777 into PEtab-dev:develop May 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants