Skip to content

Validate modelId in measurements #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Aug 21, 2025

Check that we have a valid model ID. Related to #392.

@dweindl dweindl self-assigned this Aug 21, 2025
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.66%. Comparing base (876c781) to head (9567492).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #426      +/-   ##
==========================================
+ Coverage   74.59%   74.66%   +0.07%     
==========================================
  Files          62       62              
  Lines        6735     6750      +15     
  Branches     1188     1193       +5     
==========================================
+ Hits         5024     5040      +16     
  Misses       1256     1256              
+ Partials      455      454       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dweindl dweindl marked this pull request as ready for review August 21, 2025 10:44
@dweindl dweindl requested a review from a team as a code owner August 21, 2025 10:44
Check that we have a valid model ID. Related to PEtab-dev#392.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants