Skip to content

Update v2 condition table targetValue validation #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Aug 21, 2025

After PEtab-dev/PEtab#645, any condition that is used as a first condition cannot refer to any symbols other then the parameters listed in the parameter table, or `time'.

Closes #424.

After PEtab-dev/PEtab#645, any condition that is used as a first condition cannot refer to any symbols other then the parameters listed in the parameter table, or `time'.

Closes PEtab-dev#424.
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.60%. Comparing base (876c781) to head (a00d04f).

Files with missing lines Patch % Lines
petab/v2/lint.py 76.92% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   74.59%   74.60%   +0.01%     
==========================================
  Files          62       62              
  Lines        6735     6762      +27     
  Branches     1188     1196       +8     
==========================================
+ Hits         5024     5045      +21     
- Misses       1256     1259       +3     
- Partials      455      458       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update v2 condition table targetValue validation
2 participants