Skip to content

Commit

Permalink
Fix calculate_aicc
Browse files Browse the repository at this point in the history
AICc was computed incorrectly, because nllh was used as n_estimated and vice versa when computing AIC.
  • Loading branch information
dweindl committed Dec 16, 2023
1 parent 7c71053 commit 683a2c1
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions petab_select/criteria.py
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,11 @@ def calculate_aicc(
Returns:
The AICc value.
"""
return calculate_aic(n_estimated, nllh) + 2 * n_estimated * (
n_estimated + 1
) / (n_measurements + n_priors - n_estimated - 1)
return calculate_aic(
nllh=nllh, n_estimated=n_estimated
) + 2 * n_estimated * (n_estimated + 1) / (
n_measurements + n_priors - n_estimated - 1
)


def calculate_bic(
Expand Down

0 comments on commit 683a2c1

Please sign in to comment.