Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README #69

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Update README #69

merged 1 commit into from
Dec 16, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 16, 2023

  • re-format
  • add RTD link
  • fix some typos

@dweindl
Update README
ce0e06a 
* re-format
* add RTD link
* fix some typos
@dweindl dweindl requested a review from dilpath December 16, 2023 18:41
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c71053) 60.61% compared to head (ce0e06a) 60.61%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop      #69   +/-   ##
========================================
  Coverage    60.61%   60.61%           
========================================
  Files           14       14           
  Lines         1521     1521           
========================================
  Hits           922      922           
  Misses         599      599

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dilpath
dilpath approved these changes Dec 16, 2023
View reviewed changes
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Was the formatting automatic or manual?

@dweindl
Copy link
Member Author

dweindl commented Dec 16, 2023

Nice, thanks! Was the formatting automatic or manual?

Mostly auto 😅

@dilpath
Copy link
Member

dilpath commented Dec 16, 2023

Nice, thanks! Was the formatting automatic or manual?

Mostly auto 😅

Ah, some tool like black or your IDE? I can try to integrate it into CI or pre-commit.

@dweindl
Copy link
Member Author

dweindl commented Dec 16, 2023

Nice, thanks! Was the formatting automatic or manual?

Mostly auto 😅

Ah, some tool like black or your IDE? I can try to integrate it into CI or pre-commit.

IDE. Required some intervention. For non-code, I'd only do that in a supervised manner.

@dweindl dweindl merged commit 0abaf4a into develop Dec 16, 2023
2 checks passed
@dweindl dweindl deleted the prettify_readme branch December 16, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dilpath dilpath dilpath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweindl @codecov-commenter @dilpath