Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix argument order in calculate_aicc #71

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Fix argument order in calculate_aicc #71

merged 1 commit into from
Dec 16, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 16, 2023

Fix argument order in calculate_aicc. nllh was used as n_estimated and vice versa when computing AIC.

AICc was computed incorrectly, because nllh was used as n_estimated and vice versa when computing AIC.
@dweindl dweindl requested a review from dilpath December 16, 2023 19:25
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7c71053) 60.61% compared to head (683a2c1) 60.61%.

Files Patch % Lines
petab_select/criteria.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #71   +/-   ##
========================================
  Coverage    60.61%   60.61%           
========================================
  Files           14       14           
  Lines         1521     1521           
========================================
  Hits           922      922           
  Misses         599      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AICc was computed incorrectly

Still computed correctly, since the order doesn't matter in this case, right? If so, I would rename the PR, to avoid confusion -- previous work doesn't need to be redone with this fix, since results won't change.

In any case, still an important thing, thanks a lot!

@dweindl dweindl changed the title Fix AICc calculation in calculate_aicc Fix argument order in calculate_aicc Dec 16, 2023
@dweindl
Copy link
Member Author

dweindl commented Dec 16, 2023

Still computed correctly, since the order doesn't matter in this case, right?

You are right. Doesn't matter for AIC.

If so, I would rename the PR, to avoid confusion -- previous work doesn't need to be redone with this fix, since results won't change.

Done.

@dweindl dweindl merged commit d188120 into develop Dec 16, 2023
2 checks passed
@dweindl dweindl deleted the fix_aicc branch December 16, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants