Skip to content

♻️ introduce global in CGNS trees to replace scalars and time_series mechanism #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

♻️ introduce global in CGNS trees to replace scalars and time_series mechanism #229

wants to merge 25 commits into from

Conversation

casenave
Copy link
Member

@casenave casenave commented Sep 24, 2025 •
edited
Loading

Checklist

  • Typing enforced
  • Documentation updated
  • Changelog updated
  • Tests and Example updates
  • Coverage should be 100%

Related issues

Closes #95
Closes #96

@casenave casenave requested a review from a team as a code owner September 24, 2025 04:25
@casenave casenave marked this pull request as draft September 24, 2025 04:25
@casenave casenave changed the title Globals ♻️ introduce global in CGNS trees to replace scalars and time_series mechanism Sep 24, 2025
@casenave casenave changed the title ♻️ introduce global in CGNS trees to replace scalars and time_series mechanism ♻️ introduce global in CGNS trees to replace scalars and time_series mechanism Sep 24, 2025
@codecov Codecov
Copy link

codecov bot commented Sep 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@casenave casenave added enhancement New feature or request organisation Evolution in project organisation labels Sep 24, 2025
@bstaber
Copy link
Contributor

bstaber commented Sep 25, 2025

👀

@casenave casenave marked this pull request as ready for review September 25, 2025 12:07
@casenave
Copy link
Member Author

Ready to review!

@xroynard I suppressed many things: everything related to time_series. I also remove the recent keep_cgns arg, since now as soon as there is a feature, there is alway a CGNS tree.

@xroynard
Copy link
Contributor

Ready to review!

@xroynard I suppressed many things: everything related to time_series. I also remove the recent keep_cgns arg, since now as soon as there is a feature, there is alway a CGNS tree.

Yes but does it keep the CGNS tree structure ? with Bases and Zones ? We need it for Pipelines !

@casenave
Copy link
Member Author

Ready to review!
@xroynard I suppressed many things: everything related to time_series. I also remove the recent keep_cgns arg, since now as soon as there is a feature, there is alway a CGNS tree.

Yes but does it keep the CGNS tree structure ? with Bases and Zones ? We need it for Pipelines !

I can revert this if needed no pb ^^ I'm not really sure, but I tested this with by big FNO pipeline and it works fine. Can you test your pipelines?

@casenave casenave mentioned this pull request Sep 26, 2025
Open
18 tasks
@casenave casenave marked this pull request as draft September 26, 2025 17:32
xroynard
xroynard reviewed Sep 29, 2025
View reviewed changes
@casenave casenave requested a review from xroynard October 5, 2025 07:51
@casenave casenave marked this pull request as ready for review October 5, 2025 08:21
@casenave casenave added this to the version 0.1.10 milestone Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xroynard xroynard Awaiting requested review from xroynard

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request organisation Evolution in project organisation
Projects
None yet
Milestone
version 0.1.10
Development

Successfully merging this pull request may close these issues.

Reorganize time_series and meshes to have timestamps in a single location Reorganize scalars to accept global data of any dimensions
4 participants
@casenave @bstaber @xroynard @fabiencasenave