♻️feat(links/paths) remove links/paths and CGNS linking capacities #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casenave
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
18 tasks
casenave
force-pushed
the
datasets_roadmap
branch
from
65cb63f to
d7377ba
Compare
xroynard
reviewed
Oct 9, 2025
| + "_" | ||
| + str(physical_dim) | ||
| ) | ||
| base_name = "Base_" + str(topological_dim) + "_" + str(physical_dim) |
There was a problem hiding this comment.
do you want to hard code this value ?
There was a problem hiding this comment.
it's only if base_name is not specified, it's the same behavior as before (except I removed the parameter from the classe)
xroynard
reviewed
Oct 9, 2025
| if zone_name is None: | ||
| zone_name = self._mesh_zone_name | ||
|
|
||
| zone_name = "Zone" |
There was a problem hiding this comment.
do you want to hard code this value ?
There was a problem hiding this comment.
it's only if zone_name is not specified, it's the same behavior as before (except I removed the parameter from the classe)
xroynard
reviewed
Oct 9, 2025
|
|
||
| ### Removed | ||
|
|
||
| - (sample/features) cgns links and paths, as well as args `mesh_base_name` and `mesh_zone_name` |
There was a problem hiding this comment.
oh I didn’t realize that args mesh_base_name and mesh_zone_name were also impacted by this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
🔗 Related issues (optional)
Closes #79 (not implementing)