Skip to content

🐛 feat(sample.py) add option to sample.save to solve a memory leak #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

🐛 feat(sample.py) add option to sample.save to solve a memory leak #248

wants to merge 5 commits into from
+75 −8

Conversation

casenave
Copy link
Member

@casenave casenave commented Oct 1, 2025 •
edited
Loading

Checklist

  • Typing enforced
  • Documentation updated
  • Changelog updated
  • Tests and Example updates
  • Coverage should be 100%

@casenave casenave requested a review from a team as a code owner October 1, 2025 06:30
@casenave
Copy link
Member Author

casenave commented Oct 1, 2025 •
edited
Loading

@xroynard need to discuss the best approach, this is only a first proposal of fix

@codecov Codecov
Copy link

codecov bot commented Oct 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@casenave casenave added this to the version 0.1.10 milestone Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xroynard xroynard xroynard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
version 0.1.10
Development

Successfully merging this pull request may close these issues.
3 participants
@casenave @xroynard @fabiencasenave