fix: make sure constructors don't get optimised out #1540
+2,185
−1,302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghaith
force-pushed
the
fix_arm_constructors
branch
2 times, most recently
from
5780d44 to
8c29807
Compare
…ur one is still failing. enable arm builds
ghaith
force-pushed
the
fix_arm_constructors
branch
from
18437fb to
750d3e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
llvm.usedglobal array to the modules so that constructor functions no longer get optimized out.This solves the arm init problem and no longer requires us to maintain linker scripts
As a result, the --no-linker-script flag does nothing anymore, and the default behaviour is to not force a default script.