Implement hashst(p) and hashchk(p) instructions #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcoracolombo
force-pushed
the
vccolombo-hash
branch
2 times, most recently
from
91060d0 to
5d6b078
Compare
vcoracolombo
force-pushed
the
vccolombo-hash
branch
2 times, most recently
from
02e5b07 to
5b556e4
Compare
vcoracolombo
force-pushed
the
vccolombo-hash
branch
from
5b556e4 to
c7d76f6
Compare
vcoracolombo
commented
Mar 31, 2022
Implementation for instructions hashst, hashchk, and its privileged versions. Signed-off-by: Víctor Colombo <[email protected]>
vcoracolombo
force-pushed
the
vccolombo-hash
branch
from
c7d76f6 to
c5b25fa
Compare
mferst
reviewed
Apr 5, 2022
Comment on lines
+2182
to
+2185
| for (int i = 3; i >= 0; i--) { | ||
| k[i] = key & 0xffff; | ||
| key >>= 16; | ||
| } |
There was a problem hiding this comment.
Hum... it's hard to tell if the pseudo-code is using PowerISA-indexing or everybody-else-indexing. The original paper uses "k[m-1]..k[0] = key words," so I'd expect k[0] to be the least significant halfword.
target/ppc/excp_helper.c
Outdated
| xright[0] = (x >> 16) & 0xffff; | ||
|
|
||
| for (int i = 0; i < 28; i++) { | ||
| z |= ((z0 >> (63 - i)) & 1) << 48; |
There was a problem hiding this comment.
It seems that z is set in each iteration, so I think it's not a |=. Also, why << 48?
There was a problem hiding this comment.
<< 48 was because it's setting 15th bit and I assumed it was a 64 bit variable, but it's uint16. Fixed by removing it for now, but I have yet to take a look into the bit ordering issue
| return 0; | ||
| } | ||
|
|
||
| tcg_gen_addi_tl(ea, cpu_gpr[a->ra], a->rt); |
There was a problem hiding this comment.
"If RA=0, the instruction form is invalid."
Also, if NARROW_MODE(ctx), we need a tcg_gen_ext32u_tl(ea, ea).
Add a method equivalent to CHK_SV that works with decodetree. Use it in hash instructions to optimize when CONFIG_USER_ONLY is defined. Suggested-by: Matheus Ferst <[email protected]> Signed-off-by: Víctor Colombo <[email protected]>
vcoracolombo
force-pushed
the
vccolombo-hash
branch
from
5c8f09a to
449b18b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.