Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catkinize packages #3

Merged
merged 1 commit into from
May 27, 2014
Merged

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented May 21, 2014

catkinized version of pr2_navigation:groovy-devel, this is not tested on the robot, just confirm that it is able to compile

@UltronDestroyer
Copy link
Contributor

Hi ko-kada,

I'm going to confirm it compiles. I see you also replaced the library calls with the updated hydro calls. Awesome.

Will test this on the robot sometime in the future.

@UltronDestroyer
Copy link
Contributor

This compiles if you have these additional packages from source (they haven't been released yet)
https://github.com/PR2/pr2_apps/tree/hydro-devel/pr2_teleop
https://github.com/PR2/pr2_common_actions/tree/hydro-devel/joint_trajectory_generator
https://github.com/PR2/pr2_common_actions/tree/hydro-devel/joint_trajectory_action_tools

and these additional packages from debian:
ros-hydro-laser-filters
ros-hydro-pr2-machine
ros-hydro-pr2-controllers

Strong work @k-okada & @airballking

UltronDestroyer added a commit that referenced this pull request May 27, 2014
@UltronDestroyer UltronDestroyer merged commit 5a78ba2 into PR2:groovy-devel May 27, 2014
@k-okada k-okada deleted the hydro-devel branch May 28, 2014 15:30
@k-okada
Copy link
Contributor Author

k-okada commented May 28, 2014

hi, Thanks for merging!!!

as for packages from sources, I have already catkinized packages required for this patch at
PR2/pr2_common_actions#27, so hope that is also merged soon.

I also hope to release (blooming) latest pr2_app and pr2_common_actions. I think if you run bloom on these packages, it works and bloom just skip non-catkinized package so I think it is ok, but do we need to catkinize all packages before release?

@UltronDestroyer
Copy link
Contributor

(Edit) after second thought, it's probably not necessary to wait. The only concern I have is when people go to use it and see bugs in some of the packages, they might be a bit turned off.

@airballking
Copy link

Thanks! :)

I stopped (pursuing catkinizing the downstream dependencies) when I saw the rabbit-hole related to the pr2-planning plugins: That collection of packages appeared too entangled (and deprecated) to me, and I couldn't figure out where to start --a real bonafide spaghetti problem. If any of you can point out a set of packages to start with (for catkinization), I'd be happy to further give a helping hand.

@UltronDestroyer
Copy link
Contributor

I would like to point you in a good direction, but what does pr2-planning plugins refer to?

UltronDestroyer pushed a commit that referenced this pull request Jul 13, 2014
This reverts commit 5a78ba2, reversing
changes made to 44839ed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants