-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catkinize packages #3
Conversation
Hi ko-kada, I'm going to confirm it compiles. I see you also replaced the library calls with the updated hydro calls. Awesome. Will test this on the robot sometime in the future. |
This compiles if you have these additional packages from source (they haven't been released yet) and these additional packages from debian: Strong work @k-okada & @airballking |
hi, Thanks for merging!!! as for packages from sources, I have already catkinized packages required for this patch at I also hope to release (blooming) latest pr2_app and pr2_common_actions. I think if you run bloom on these packages, it works and bloom just skip non-catkinized package so I think it is ok, but do we need to catkinize all packages before release? |
(Edit) after second thought, it's probably not necessary to wait. The only concern I have is when people go to use it and see bugs in some of the packages, they might be a bit turned off. |
Thanks! :) I stopped (pursuing catkinizing the downstream dependencies) when I saw the rabbit-hole related to the pr2-planning plugins: That collection of packages appeared too entangled (and deprecated) to me, and I couldn't figure out where to start --a real bonafide spaghetti problem. If any of you can point out a set of packages to start with (for catkinization), I'd be happy to further give a helping hand. |
I would like to point you in a good direction, but what does pr2-planning plugins refer to? |
catkinized version of pr2_navigation:groovy-devel, this is not tested on the robot, just confirm that it is able to compile