Skip to content

[HOLD - do not merge] fix: add missing env variables for scheduler #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
drtechie wants to merge 1 commit into from
Closed

[HOLD - do not merge] fix: add missing env variables for scheduler #231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,3 +173,21 @@ failedLoginAttempt=5
jwt.access.expiration=86400000
jwt.refresh.expiration=604800000


##-------------------------------###cti data sync Scheduler configurations------------------------------------------------------

#Runs at every alternative days at 2AM
start-ctidatasync-scheduler=true
cron-scheduler-ctidatasync=0 30 01 * * ? *

Comment on lines +176 to +182

@coderabbitai coderabbitai Bot Jun 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Mismatch between cron and description for CTI data sync scheduler
The cron expression 0 30 01 * * ? * schedules a job daily at 1:30 AM—not every other day at 2 AM as the comment suggests. Update either the cron pattern (e.g., 0 30 01 1/2 * ? * for alternate days at 1:30 AM) or correct the comment/time details.

🤖 Prompt for AI Agents 
In src/main/resources/application.properties around lines 176 to 182, the
comment states the CTI data sync scheduler runs every other day at 2 AM, but the
cron expression schedules it daily at 1:30 AM. To fix this, either update the
cron expression to run every other day at the intended time (e.g., use a pattern
like '0 0 2 1/2 * ? *' for 2 AM every other day) or adjust the comment to
accurately reflect the current cron schedule.

##-------------------------------###cti data check with call detail report Scheduler------------------------------------------------------

#Runs at everyday 12:10AM
start-ctidatacheck-scheduler=true
cron-scheduler-ctidatacheck=0 00 02 * * *

Comment on lines +183 to +188

@coderabbitai coderabbitai Bot Jun 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Incorrect cron field count & comment mismatch for CTI data check scheduler
The line cron-scheduler-ctidatacheck=0 00 02 * * * uses a 6-field cron (missing the day-of-week placeholder) and conflicts with the comment “Runs at everyday 12:10 AM.” For Quartz compatibility, use 7 fields with ? for day-of-week (e.g., 0 10 00 * * ? * for 12:10 AM) or align both the cron and comment to the intended time.

🤖 Prompt for AI Agents 
In src/main/resources/application.properties around lines 183 to 188, the cron
expression for ctidatacheck scheduler uses 6 fields instead of the required 7
for Quartz and does not match the comment time of 12:10 AM. Update the cron
expression to have 7 fields with a '?' for day-of-week, for example, '0 10 0 * *
? *' to run at 12:10 AM daily, or adjust the comment to match the actual cron
time if you want to keep the current schedule.


##-----------------------------------------------#NHM data dashboard schedular----------------------------------------------------------------
# run at everyday 12:01AM
start-nhmdashboard-scheduler=true
cron-scheduler-nhmdashboard=0 30 0 * * ? *
Comment on lines +190 to +193

@coderabbitai coderabbitai Bot Jun 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Typo and mismatch in NHM data dashboard scheduler config
The comment “run at everyday 12:01 AM” does not match the cron 0 30 0 * * ? * (12:30 AM). Also, fix “schedular” → “scheduler” for clarity. Update the cron or comment to the correct time and correct the spelling.

🤖 Prompt for AI Agents 
In src/main/resources/application.properties around lines 190 to 193, correct
the typo "schedular" to "scheduler" in the comment. Also, ensure the comment
time matches the cron expression: either update the comment to say "run at
everyday 12:30 AM" to match the cron "0 30 0 * * ? *" or change the cron to "0 1
0 * * ? *" if the intended time is 12:01 AM.