Skip to content

Fix: Prevent silent deletion of offline records during down-sync #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vibhutomer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Prevent silent deletion of offline records during down-sync #454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/src/main/java/org/piramalswasthya/sakhi/repositories/SaasBahuSammelanRepo.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ class SaasBahuSammelanRepo @Inject constructor(
Log.e("AHJAHA",body)
val adapter = moshi.adapter(SaasBahuSammelanGetAllResponse::class.java)
val parsed = adapter.fromJson(body) ?: return@withContext
val unsyncedRecords = saasBahuDao.getBySyncState(SyncState.UNSYNCED)
saasBahuDao.clearAll()
Comment on lines +169 to 170

@coderabbitai coderabbitai Bot May 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | 🏗️ Heavy lift

Make the destructive refresh atomic to fully eliminate offline data loss.

If anything throws after Line 170 and before Line 204 (parse/insert/null assertion, cancellation, etc.), the cached UNSYNCED records are never restored and local offline work is still lost. Please wrap fetch-unsynced → clear → server insert → restore in one Room transaction (or minimally restore in finally as a fallback).

Also applies to: 204-206

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@app/src/main/java/org/piramalswasthya/sakhi/repositories/SaasBahuSammelanRepo.kt`
around lines 169 - 170, Wrap the destructive refresh (fetching unsyncedRecords
via saasBahuDao.getBySyncState, saasBahuDao.clearAll, server inserts/parsing and
the subsequent restore) in a single Room transaction or at minimum ensure
unsyncedRecords are restored in a finally block; specifically, use your
RoomDatabase.runInTransaction { ... } around the sequence that calls
saasBahuDao.getBySyncState and saasBahuDao.clearAll and the insert calls, or
enclose clearAll + server insert in try { ... } catch { throw } finally { if
(unsyncedRecords.isNotEmpty()) saasBahuDao.insertAll(unsyncedRecords) } so that
any exception/cancellation won’t permanently lose the cached UNSYNCED records.

parsed.data?.forEach { item ->
val imageBase64List = item.meetingImages ?: emptyList()
Expand Down Expand Up @@ -200,6 +201,9 @@ class SaasBahuSammelanRepo @Inject constructor(

saasBahuDao.insertSammelan(entity)
}
unsyncedRecords.forEach {
saasBahuDao.insertSammelan(it)
}
}


Expand Down