Skip to content

Fix: Implement Mutex lock in up-sync to prevent race conditions and d… #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vibhutomer wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Implement Mutex lock in up-sync to prevent race conditions and d… #456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions app/src/main/java/org/piramalswasthya/sakhi/repositories/SaasBahuSammelanRepo.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ import java.io.File
import java.net.SocketTimeoutException
import javax.inject.Inject
import kotlin.collections.forEach
import kotlinx.coroutines.sync.Mutex
import kotlinx.coroutines.sync.withLock

class SaasBahuSammelanRepo @Inject constructor(
private val userRepo: UserRepo,
Expand All @@ -43,6 +45,8 @@ class SaasBahuSammelanRepo @Inject constructor(


) {

private val syncMutex = Mutex()

suspend fun saveSammelanForm(saasBahuSammelanCache: SaasBahuSammelanCache) {
withContext(Dispatchers.IO) {
Expand All @@ -52,13 +56,14 @@ class SaasBahuSammelanRepo @Inject constructor(

suspend fun pushUnSyncedRecordsSaasBahuSammelan(): Boolean {

return withContext(Dispatchers.IO) {
return syncMutex.withLock { withContext(Dispatchers.IO) {
val user =
preferenceDao.getLoggedInUser()
?: throw IllegalStateException("No user logged in!!")

val saasBahuList: List<SaasBahuSammelanCache> =
saasBahuDao.getBySyncState(SyncState.UNSYNCED)
if (saasBahuList.isEmpty()) return@withContext true
try {
saasBahuList.forEach { row ->
val imagesParts = (row.sammelanImages ?: emptyList()).mapNotNull { uriStr ->
Expand Down Expand Up @@ -134,7 +139,7 @@ class SaasBahuSammelanRepo @Inject constructor(
return@withContext false
}
true
}
}}
}


Expand Down