Mavlink: implemented SCALED_PRESSURE streams#14270
Merged
Merged
Conversation
Member
|
The change looks good, it's just pushing px4_fmu-v2 over the flash limit. Let me see what we can do. |
Contributor
Author
With the new commit, I could reduce the size a bit by adding a constexpr qualifier to get_name_static and get_id_static. I also commented out SCALED_PRESSURE2 and SCALED_PRESSURE3, as my goal at the moment is to get the barometric temperature via mavros which needs only SCALED_PRESSURE. They can easily be added later. Before this PR: Without the latest commit: With the latest commit: |
and constexpr for get_id_static and get_name_static in mavlink streams
1429713 to
b7da78e
Compare
Member
|
Nice one! Looks like it now more than pays for itself on fmu-v2. |
dagar
approved these changes
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe problem solved by this pull request
mavros expects SCALED_PRESSURE at the moment to send the barometer temperature. With this PR, PX4 is able to send SCALED_PRESSURE/SCALED_PRESSURE2/SCALED_PRESSURE3.
Describe your solution
We subscribe directly to sensor_baro and forward the absolute pressure and temperature.
Describe possible alternatives
The template can be removed if SCALED_PRESSURE would contain a sensor index, similar to mavlink/rfcs#13.
Test data / coverage