Fix NuttX build under Cygwin#16040
Conversation
after NuttX 9.1.0+ upgrade #15139
| else | ||
| ARCHSCRIPT = -T$(BOARD_DIR)$(DELIM)scripts$(DELIM)flash.ld | ||
| ifeq ($(CONFIG_BOARD_USE_PROBES),y) | ||
| ARCHINCLUDES += -I $(TOPDIR)/arch/$(CONFIG_ARCH)/src/$(CONFIG_ARCH_CHIP) -I $(TOPDIR)/arch/$(CONFIG_ARCH)/src/common |
There was a problem hiding this comment.
@davids5 I shifted these additions up because they need to get converted as well and added spaces between -I and the path for simpler makefile parsing.
|
@MaEtUgR - can we re-enable the windows CI build now? |
|
@MaEtUgR thanks for work, windows builds ok again. |
|
@lukegluke Thanks for the feedback. I'm currently assuming that's a general build system issue and not specific to the Windows toolchain. We should check that. Could you make a separate issue for that problem and tag me? |
|
Done! |
Describe problem solved by this pull request
NuttX build using the Cygwin Toolchain is broken since the NuttX 9.1.0+ upgrade #15139 . The pr was merged nevertheless to unblock core developers using the new NuttX version and with the intent to fix the build shortly after. PX4 stable v1.11 was the officially recommended version to build in case you ran into any problems.
Fixes #15760
Describe your solution
It took me quite some time to figure out:
ARCHINCLUDESeven before the makefile made a new way of converting the include paths that are already inside compile flags necessaryTest data / coverage
So far I build
px4_fmu-v4locally but didn't do any hardware tests yet.Additional context
