Param tooling#20385
Open
coderkalyan wants to merge 5 commits into
Open
Conversation
A little bit of code cleanup in preparation for using srcparser to migrate the c parameter files to yaml definitions. * dataclasses * PEP 8-ish
Fixes a bug where any boolean tag that exists, whether or not the value is actually true, is recorded as true in parameter generation.
coderkalyan
force-pushed
the
param-tooling
branch
from
6281469 to
3639c73
Compare
bkueng
reviewed
Oct 10, 2022
| default_port_str = port_config['default'] | ||
|
|
||
| if default_port_str != "": | ||
| if default_port_str != "" and default_port_str != 0: |
Member
There was a problem hiding this comment.
Didn't you mention that this wasn't needed anymore?
Contributor
|
@coderkalyan Thanks for this contribution! Could you resolve the merge conflict & apply the requested changes? |
Contributor
Author
|
@junwoo091400 once again I forgot about this PR :) Sure thing, I'll review the changes when I get a chance and rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the tooling part of #19489, rebased and cherry-picked so it can be reviewed and merged easily before we finish the rest of the parameter migration.
@bkueng Would appreciate a review from you, I don't have permissions to mark it on the PR itself though.
FYI @dagar