Skip to content

EKF2: use dedicated time-delay parameter#22983

Merged
dagar merged 1 commit into
mainfrom
pr-ekf2-buffer-size
Apr 17, 2024
Merged

EKF2: use dedicated time-delay parameter#22983
dagar merged 1 commit into
mainfrom
pr-ekf2-buffer-size

Conversation

@bresch
Copy link
Copy Markdown
Member

@bresch bresch commented Apr 5, 2024

Requires:

Solved Problem

  1. It is quite common to enable/disable an aiding source after takeoff to test the robustness of the system. With the current way of calculating the delayed time horizon, booting with or without an aiding source enabled leads to different results (especially for GNSS as it usually has the highest delay).
  2. VIO systems are time-synchronized, meaning that their delay parameter is set to 0 but the actual delay is usually much higher, a known workaround is to set the VIO delay in the auxvel delay to size the buffer correctly.

Solution

Add EKF2_DELAY_MAX parameter to define the delay between the current time and delayed-time horizon.

Changelog Entry

For release notes:

New parameter: EKF2_DELAY_MAX
Documentation: TBD

Todo:

  • bump EKF2_MAX_DELAY if smaller than sensor-specific delay

Screenshot from 2024-04-17 10-46-50

@bresch bresch self-assigned this Apr 5, 2024
@bresch bresch force-pushed the pr-ekf2-buffer-size branch from 6b9e8e4 to e39b16a Compare April 5, 2024 13:11
@bresch bresch changed the base branch from main to pr-migrate-c-params April 5, 2024 13:11
@bresch bresch requested a review from dagar April 5, 2024 13:12
@bresch bresch added the EKF2 label Apr 5, 2024
@bresch bresch force-pushed the pr-ekf2-buffer-size branch from e39b16a to 1773aaa Compare April 5, 2024 13:13
Comment thread src/modules/ekf2/module.yaml Outdated
@bresch bresch force-pushed the pr-migrate-c-params branch 2 times, most recently from 9be6bd1 to d53e1bd Compare April 16, 2024 14:58
Base automatically changed from pr-migrate-c-params to main April 16, 2024 15:14
@bresch bresch force-pushed the pr-ekf2-buffer-size branch from 28e7a34 to 7ee5338 Compare April 17, 2024 08:44
Some sensors can have their delay included in the timestamp. In this
case, the buffer cannot be sized using the _DELAY parameter.
@bresch bresch force-pushed the pr-ekf2-buffer-size branch from 7ee5338 to c44d8cb Compare April 17, 2024 08:47
@bresch bresch marked this pull request as ready for review April 17, 2024 08:47
@bresch
Copy link
Copy Markdown
Member Author

bresch commented Apr 17, 2024

@dagar I added the param set to bump the max_delay and increased its default value to 200ms.

@dagar dagar merged commit a8a67fb into main Apr 17, 2024
@dagar dagar deleted the pr-ekf2-buffer-size branch April 17, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants