Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message versioning and ROS 2 message translation #3465

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

GuillaumeLaine
Copy link
Contributor

@GuillaumeLaine GuillaumeLaine commented Nov 20, 2024

This documents the newly versioned subset of PX4 messages, and the ROS 2 translation node that enables seamless communication between PX4 and ROS 2 applications that may be using different message definition versions.

Related Work

To Do

  • Complete TODOs in the markdown of this PR

en/ros2/user_guide.md Outdated Show resolved Hide resolved
@GuillaumeLaine GuillaumeLaine force-pushed the message-versioning branch 3 times, most recently from 41873cf to 825115e Compare December 18, 2024 13:01
@GuillaumeLaine GuillaumeLaine changed the title WIP: message versioning Message versioning and ROS 2 message translation Dec 18, 2024
@GuillaumeLaine GuillaumeLaine force-pushed the message-versioning branch 4 times, most recently from 3c869fb to 2a3af80 Compare December 18, 2024 13:57
@GuillaumeLaine GuillaumeLaine marked this pull request as ready for review December 18, 2024 13:57
@GuillaumeLaine
Copy link
Contributor Author

@hamishwillee I think the PR is in a review ready state. I left a few TODOs in the markdown to resolve before merging. Mostly things that I need to go back to once the last related PR is merged

en/releases/main.md Outdated Show resolved Hide resolved
en/releases/main.md Outdated Show resolved Hide resolved
en/ros2/user_guide.md Outdated Show resolved Hide resolved
en/middleware/uorb.md Outdated Show resolved Hide resolved
en/middleware/uorb.md Outdated Show resolved Hide resolved
en/middleware/uorb.md Outdated Show resolved Hide resolved
en/middleware/uorb.md Outdated Show resolved Hide resolved
en/middleware/uorb.md Outdated Show resolved Hide resolved
en/releases/main.md Outdated Show resolved Hide resolved
en/ros2/user_guide.md Outdated Show resolved Hide resolved
@hamishwillee
Copy link
Collaborator

@GuillaumeLaine Thanks for your comments. I can see we're getting pretty close. Any ETA on when PX4/PX4-Autopilot#24113 will get in?

@GuillaumeLaine
Copy link
Contributor Author

@hamishwillee The implementation PR is ready to merge in my opinion, it's all good from a user workflow perspective when I tested it. There hasn't been much activity from the community but FWIW I've just given my approval, I think we can expect it to get merged soon

@hamishwillee
Copy link
Collaborator

hamishwillee commented Jan 30, 2025

Thanks for the update @GuillaumeLaine - really appreciate your attention to detail. I am happy for this to go in. There are just two outstanding suggestions for your consideration:

Copy link

No flaws found

@hamishwillee
Copy link
Collaborator

@GuillaumeLaine I don't have any other comments. Looks good to go in when the code PR goes in.

@GuillaumeLaine
Copy link
Contributor Author

@hamishwillee Awesome thanks! Really appreciate you taking the time to refine things until they're right 🙌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants