-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Message versioning and ROS 2 message translation #3465
base: main
Are you sure you want to change the base?
Conversation
a0c25d8
to
ac87603
Compare
ac87603
to
66ced5a
Compare
41873cf
to
825115e
Compare
3c869fb
to
2a3af80
Compare
2a3af80
to
22a480e
Compare
@hamishwillee I think the PR is in a review ready state. I left a few |
22a480e
to
8d080d2
Compare
@GuillaumeLaine Thanks for your comments. I can see we're getting pretty close. Any ETA on when PX4/PX4-Autopilot#24113 will get in? |
Co-authored-by: bkueng <[email protected]> Co-authored-by: Hamish Willee <[email protected]>
ba8dd9a
to
cd7e2cb
Compare
@hamishwillee The implementation PR is ready to merge in my opinion, it's all good from a user workflow perspective when I tested it. There hasn't been much activity from the community but FWIW I've just given my approval, I think we can expect it to get merged soon |
Thanks for the update @GuillaumeLaine - really appreciate your attention to detail. I am happy for this to go in. There are just two outstanding suggestions for your consideration: |
No flaws found |
@GuillaumeLaine I don't have any other comments. Looks good to go in when the code PR goes in. |
@hamishwillee Awesome thanks! Really appreciate you taking the time to refine things until they're right 🙌🏻 |
This documents the newly versioned subset of PX4 messages, and the ROS 2 translation node that enables seamless communication between PX4 and ROS 2 applications that may be using different message definition versions.
Related Work
To Do
TODO
s in the markdown of this PR