Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

video_streaming - Update QGC streaming doc link #3554

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

hamishwillee
Copy link
Collaborator

Fixes #3430

@@ -30,7 +30,7 @@ To setup and use video steaming with QGC:
sudo apt install gstreamer1.0-plugins-bad gstreamer1.0-libav gstreamer1.0-gl -y
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DonLakeFlyer @HTRamsey This is the source for the PX4 instructions for installing the GStreamer on Ubuntu for working with QGC.

The linked https://github.com/mavlink/qgroundcontrol/blob/master/src/VideoManager/VideoReceiver/GStreamer/README.md suggests something like this

Suggested change
sudo apt install gstreamer1.0-plugins-bad gstreamer1.0-libav gstreamer1.0-gl -y
list=$(apt-cache --names-only search ^gstreamer1.0-* | awk '{ print $1 }' | sed -e /-doc/d | grep -v gstreamer1.0-hybris)
sudo apt-get install $list
sudo apt-get install libgstreamer-plugins-base1.0-dev libgstreamer-plugins-bad1.0-dev -y

Is the PX4 variant "wrong" - i.e. for Ubuntu can I leave it as it is, or should we be using the same instructions as in QGC tree?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PX4 variant just includes runtime dependencies (which are included in the AppImage in v5, unlike v4.X) while the QGC one includes build-time libs but also unnecessarily installs literally everything gstreamer related. We've just been relying on a build script (https://github.com/mavlink/qgroundcontrol/blob/master/tools/setup/install-dependencies-debian.sh) that we can update without having to update instructions like these in the future.

There is also a good likelihood that the main/default video receiver switches to QGC provided ffmpeg libs which would mean no additional libs are required and would resolve all the problems that have existed due to GStreamer's difficulty to work with.

Not 100% sure how to handle this at the moment.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @HTRamsey !

OK, so I have added a note that this step is not required for daily builds and releases after QGC4 - is that correct? (or is it only correct for Appimages)

  1. So what of step 1 in https://docs.qgroundcontrol.com/master/en/qgc-user-guide/getting_started/download_and_install.html#ubuntu is no longer required for daily builds? As this is "main" we should document the daily build behaviour - but with a note that for release builds you still have to do the old steps.
  2. Does it make sense to update https://github.com/mavlink/qgroundcontrol/blob/master/src/VideoManager/VideoReceiver/GStreamer/README.md to refer to https://github.com/mavlink/qgroundcontrol/blob/master/tools/setup/install-dependencies-debian.sh as well?

Copy link

No flaws found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants