Encrypted logs #306
Encrypted logs #306
Conversation
|
I tested the following:
Regarding:
I can take care of them , see my answer above for your question regarding parsing! |
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
|
This pull request has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there: |
| if not os.path.exists(private_key_path): | ||
| raise FileNotFoundError(f"Private key not found at {private_key_path}") |
There was a problem hiding this comment.
This could be checked on startup (if the path is set in the config)
There was a problem hiding this comment.
It could be, but in that case I think a variable should be added to avoid checking it when working with normal logs
Added the key path to the config, modified the logic accordingly Created local method in upload.py and modified the logic slightly
|
@bkueng I made most of the suggested modifications and left a comment for the rest. |
There was a problem hiding this comment.
There's a few minor CI failures: https://github.com/PX4/flight_review/actions/runs/14179570507/job/39750863306?pr=306
app/config_default.ini
Outdated
| @@ -23,6 +23,9 @@ mapbox_api_access_token = | |||
| # available RAM and Log file size. Should be a power of 2. | |||
| log_cache_size = 8 | |||
|
|
|||
| # Encryption key | |||
| ulge_private_key = ../private_key/private_key.pem | |||
There was a problem hiding this comment.
Can you keep this empty by default? You could add it as a comment.
Added logic to handle encrypted logs(.ulge) files