Skip to content

Conversation

mhsdesign
Copy link
Contributor

@mhsdesign mhsdesign commented Apr 9, 2023

previously, every external type lookup will result in re-parsing

... but i guess it would better if we could cache ModuleNode::fromTokens

maybe by having a factory where we can cache by source like $moduleNodeFactory->createFromSource($source) -> then we can use this factory here ...

previously, every external type lookup will result in re-parsing
@mhsdesign mhsdesign changed the title Task: cache ModuleFileLoader::resolveTypeOfImport WIP: TASK: cache ModuleFileLoader::resolveTypeOfImport Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant