Skip to content

[SOT][3.12] add LOAD_FAST_CHECK OpCode - #62218

Merged
SigureMo merged 1 commit into
PaddlePaddle:developfrom
gouzil:sot_add_LOAD_FAST_CHECK
Mar 1, 2024
Merged

[SOT][3.12] add LOAD_FAST_CHECK OpCode#62218
SigureMo merged 1 commit into
PaddlePaddle:developfrom
gouzil:sot_add_LOAD_FAST_CHECK

Conversation

@gouzil

@gouzil gouzil commented Feb 29, 2024

Copy link
Copy Markdown
Member

PR types

Others

PR changes

Others

Description

增加LOAD_FAST_CHECK OpCode

参考链接:

相关链接:

TODO: instruction_pass 补充 LOAD_FAST_CHECK

@paddle-bot

paddle-bot Bot commented Feb 29, 2024

Copy link
Copy Markdown

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot Bot added the contributor External developers label Feb 29, 2024
@SigureMo SigureMo self-assigned this Feb 29, 2024
@gouzil
gouzil requested a review from SigureMo February 29, 2024 08:07
@gouzil

gouzil commented Feb 29, 2024

Copy link
Copy Markdown
Member Author

或许我们应该跟RETURN一样也合并一下这两个字节码

@SigureMo

Copy link
Copy Markdown
Member

或许我们应该跟RETURN一样也合并一下这两个字节码

考虑过,但没必要为这一个做,以后版本再观察观察

@SigureMo SigureMo closed this Feb 29, 2024
@SigureMo SigureMo reopened this Feb 29, 2024

@SigureMo SigureMo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow

@SigureMo
SigureMo merged commit 12d1ecb into PaddlePaddle:develop Mar 1, 2024
@gouzil
gouzil deleted the sot_add_LOAD_FAST_CHECK branch April 23, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants