Skip to content

Conversation

@liu-jiaxuan
Copy link
Collaborator

No description provided.

Copy link
Member

@Bobholamovic Bobholamovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 需确认是否使用了pre-commit进行自动代码风格检查;
  2. 新增代码量超过了9000行,需评估这些代码是否都是必要的;
  3. 需评估RT-DETR-L是否应该只是RT-DETR的一个变体(通过配置文件确定),考虑到transformers库是这样设计的(https://huggingface.co/docs/transformers/main/model_doc/rt_detr)。

__all__ = ["HungarianMatcher"]


class GIoULoss(object):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

目前代码量有点儿太多了,我们只是做推理的话,loss部分是否可以不迁移进来?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RT-DETR-L模型组件HungarianMatcher依赖GIoULoss运行,此处需要进行迁移

return out_bbox if format == "xyxy" else bbox_xyxy_to_cxcywh(out_bbox)


def varifocal_loss_with_logits(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也有不少loss相关内容

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RT-DETR-L模型组件DINOHead、RTDETRTransformer组件依赖utils中各loss相关方法运行,此处需要进行迁移

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants