Credentials file comments and PowerShell USERPROFILE for home directory #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments in credentials files
…hell, this will account for one of those cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We found that the library fails if there are any comments in the credentials json files so to handle this I use the json5 library instead of the base json library that comes with python at this time.
https://pypi.org/project/json5/
I also saw the library fail to find credential files when using PowerShell because the environment variable HOME would be missing. I set it to fall back onto USERPROFILE if the HOME variable is not set.
I also added more descriptive notes on how to test locally in the CONTRIBUTING.md file.
Motivation and Context
How Has This Been Tested?
I tested locally in a minimal capacity.
Types of changes
Checklist