Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modified Function: Updated the pull_config_sites function to handle additional site categories "ALL_DCS" (Data Centers) and "ALL_BRANCHS" (Branches).
Parameters Updated:
sites: Added options "ALL_DCS" and "ALL_BRANCHS" to the list of site categories.
output_filename: No changes.
output_multi: No changes.
New Logic Implemented:
Pulls configurations specifically for Data Centers ("HUB" role) and Branches ("SPOKE" role) sites.
Handles scenarios where no matching sites are found, providing appropriate error messages.
Motivation and Context
Reason for Change: This change was required to enhance the flexibility of the configuration pull function, allowing it to retrieve configurations not only for all sites ("ALL_SITES") but also specifically for data centers ("ALL_DCS") and branch sites ("ALL_BRANCHS").
Problem Solved: Previously, the function only supported pulling configurations for all sites, without the ability to target specific types of sites. This update allows for more granular control and streamlined configuration retrieval.
How Has This Been Tested?
Testing Environment: Tested in a staging environment with multiple site configurations, including data centers and branches.
Tests Performed:
Ran the updated pull_config_sites function with the new "ALL_DCS" and "ALL_BRANCHS" options.
Verified that the function correctly retrieves and saves the configurations for the specified site types.
Confirmed that error messages are correctly displayed when no matching sites are found.
Screenshots (if appropriate)
NA
Types of changes
Checklist