feat(channels): add Xianyu(闲鱼) support#181
Conversation
|
Hi @wby1121, thanks for adding Xianyu support! The channel implementation looks interesting. 👍 Before we can merge, a few things need to be addressed: 1. Remove files that shouldn't be in the PR
2. Add a PR descriptionPlease add a brief description explaining:
3. Rebase onto latest
|
cb0f029 to
e9e01c5
Compare
e9e01c5 to
b2e843e
Compare
|
Hi @Panniantong, Thanks for the review — updated now. I removed the extra files from the PR, rebased onto the latest I also cleaned up the setup wording so it clearly reflects that this integration uses Verified with:
|
Panniantong
left a comment
There was a problem hiding this comment.
感谢贡献闲鱼 channel!核心的 xianyu.py 实现质量不错(check() 分层验证、测试覆盖完整),但这个 PR 的改动范围远超预期,有几处必须修改:
必须回滚的改动:
-
不能删除 XueqiuChannel(雪球)注册和测试:雪球是现有的完整功能 channel,删除会造成功能倒退。请恢复 channels/init.py 中的 XueqiuChannel,以及 tests/ 中的雪球测试。
-
bird -> xreach 的 Twitter 工具迁移不属于本 PR 范围:这是独立的系统性变更,请拆出去单独开 PR。当前项目已迁移到 bird CLI,请勿在此 PR 中改回 xreach。
-
CLI 功能删除(skill --install/--uninstall、format xhs、OPENCLAW_HOME 等)未在 PR 描述中说明,且这些是破坏性变更。请恢复或单独开 PR 讨论。
可以保留的改动:
- xianyu.py 新文件 ✅
- 在 init.py 中添加 XianyuChannel(但不删 XueqiuChannel)✅
- 闲鱼相关的文档和配置引导 ✅
- TestXianyuChannel 测试 ✅
建议做法:
- 在此 PR 中只保留添加闲鱼 channel 的最小改动
- 将 Twitter 工具迁移(如果确实需要)单独开 PR
- 把 XueqiuChannel 恢复后重新请求 review
很期待闲鱼功能合并!
|
已按 review 建议收敛这条 PR,感谢指出范围问题。 这次我已经把无关改动撤回,只保留“新增闲鱼 channel”的最小改动,主要调整如下:
另外我已经重新跑过测试: python3 -m pytest tests/ -q结果: 现在这条 PR 应该只包含闲鱼 support 的最小必要改动。 |
Summary
This PR adds Xianyu support through a new
XianyuChannel.The integration is built on top of
mcporterwith the Node-basedmcp-goofishbackend. It adds:mcporter, and MCP availabilityAuth / setup
This integration is not zero-config.
It requires:
mcportermcp-goofishDependencies
No new Python dependency is introduced in this PR.
The only external dependency is the Node-based
mcp-goofishtool used throughmcporter.Notes
I also removed files that should not have been included in the PR and rebased the branch onto the latest
main.