Skip to content

Add English skill locale support#223

Open
Chewy-b0t wants to merge 1 commit intoPanniantong:mainfrom
Chewy-b0t:chewy/english-skill-locale
Open

Add English skill locale support#223
Chewy-b0t wants to merge 1 commit intoPanniantong:mainfrom
Chewy-b0t:chewy/english-skill-locale

Conversation

@Chewy-b0t
Copy link
Copy Markdown

Summary

  • add an English SKILL_en.md variant for Agent Reach
  • auto-install the English skill file when the locale is English or AGENT_REACH_LANG=en
  • document the English-skill install path in docs/README_en.md
  • add a test for English locale installs

Why

The repo already has an English README, but installed skill files are still mixed-language. This makes local agent installs feel inconsistent for English users and causes English-only local customizations to get overwritten on updates.

This keeps the default Chinese/mixed skill path intact while adding a low-risk English path for users who want it.

Testing

  • /home/y/.agent-reach-venv/bin/python -m unittest tests.test_skill_command -v

Copy link
Copy Markdown
Owner

@Panniantong Panniantong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢提交!方向很好,英文 skill 支持是有价值的功能。需要几处修改后才能合并:

必须修复:

  1. ** 内容矛盾**:文件开头写的是 "17 platforms" 和 "13+ platforms" 两处数字不一致,请统一为一个准确的数字(对照中文 SKILL.md)。

  2. ** 未注册新文件**:若 SKILL_en.md 未加入 package_data,打包后 importlib.resources 会找不到该文件。请确认 pyproject.toml 中已正确包含 SKILL_en.md

  3. 安装覆盖问题:中英文版安装后文件名都叫 SKILL.md,会互相覆盖。请在 PR 描述或文档中明确说明这是有意设计(切换语言需重新安装)。

建议优化(非阻塞):

  1. locale 检测逻辑建议改为逐个变量检查(而非 " ".join() 后匹配),可读性更好,边界情况更清晰。

  2. 测试中 assertIn('Triggers: "search twitter"', content) 耦合了文件内容的具体字符串,建议改为检查文件存在且非空,或用更稳定的断言方式。

修复以上第 1-3 条后可重新请求 review,很期待合并这个功能!

Copy link
Copy Markdown
Owner

@Panniantong Panniantong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢提交!方向很好,英文 skill 支持是有价值的功能。需要几处修改后才能合并:

必须修复:

  1. SKILL_en.md 内容矛盾:文件开头 description 里 17 platforms 和 13+ platforms 两处数字不一致,请统一(对照中文 SKILL.md)。

  2. pyproject.toml 未注册新文件:若 SKILL_en.md 未加入 package_data,打包后 importlib.resources 会找不到该文件,英文 skill 无法生效。请检查并添加。

  3. 安装覆盖问题:中英文版安装后文件名都叫 SKILL.md,会互相覆盖。请在 PR 描述或文档中明确说明这是有意设计(切换语言需重新 agent-reach skill --install)。

建议优化(非阻塞):

  1. locale 检测建议逐个变量检查,而非 join 后字符串匹配,边界情况更清晰。

  2. 测试中 assertIn 耦合了文件内容具体字符串,建议改为更稳定的断言。

修复 1-3 条后可重新请求 review,期待合并!

@Chewy-b0t Chewy-b0t force-pushed the chewy/english-skill-locale branch from a6c16a7 to 7d0ba7b Compare March 31, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants