-
-
Notifications
You must be signed in to change notification settings - Fork 194
Particles 1.21.9 #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Particles 1.21.9 #651
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
be4023d
to
b91aa9c
Compare
b91aa9c
to
b3b8b91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm from an editorial standpoint, going to merge this once 1.21.10 becomes stable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming the content is correct, looks fine style wise
export const LATEST_PAPER_RELEASE = await findLatest(paperProject); | ||
// export const LATEST_PAPER_RELEASE = await findLatest(paperProject); | ||
export const LATEST_PAPER_RELEASE = "1.21.10"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we maybe want to revert this before merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once 1.21.10 is stable and can be resolved by that call, yes
This PR updates docs to match changes to particles in 1.21.9. As of writing this comment 1.21.9 is not out yet and therefore JD links are missing for SpellColorOptions and whatever will be used for dragon breath's power argument.