clang/find_clang.cr: Auto-detect if linking libclang using .a or .so #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArchLinux has changed their mind in the meantime. Didn't feel like messing with the environment variable, instead, it's supposed to auto-detect now if libclang.a or libclang.so exist. If both static and dynamic versions are available it'll prefer the static library, which is hopefully more stable when the user decides to update their system. The user can still use BINDGEN_DYNAMIC=1/0 as before, but simply not setting it will trigger the auto-detection. Also, the pattern-matching style "case" statement of Crystal is some good stuff!
|
Hey @Papierkorb I think we already covered this previously and it was working in both cases. But @ZaWertun and @kalinon would be better to comment, since the current implementation came from them. |
|
(Or, on a second thought, maybe you are right. Currently there is no autodetection (DYNAMIC needs to be set manually), and the feature/change which I was thinking about was the one where we just made sure that we only linked against .a's or .so's, and not both.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Was toying with bindgen today and noticed that ArchLinux joined the
distros who want static linking of libclang. It annoyed me so in OSS
fashion I decided to do something about it.
If both static and dynamic versions are available it'll prefer the
static library, which is hopefully more stable when the user decides
to update their system. The user can still use
BINDGEN_DYNAMIC=1/0as before, but simply not setting it will trigger the auto-detection.
However this could break stuff horribly on non-ArchLinux machines,
so I PR'd this before I break
masterout of the blue. Does this work foreveryone?
Also,
find_clang.crhas code to read the OS name to force the defaultto static linking on a bunch of distros - Do we still need this code with
this change?
Cheers!