Skip to content

Ped Randomizer: Allow specifying multiple models in ForcePed #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pongo1231
Copy link
Collaborator

Implements #19

@Parik27
Copy link
Owner

Parik27 commented Feb 20, 2022

Thanks for the pull request, but it makes it so that the ForcedPed config option can't be changed using the debug menu.

It'd be better to provide an override for it in the config reading code and the config debug interface code.

@pongo1231 pongo1231 force-pushed the forceped_multiple_models branch from 54cfa1f to 5c5c0ae Compare April 12, 2022 00:50
@pongo1231
Copy link
Collaborator Author

Works with the debug menu now, however right now it'll store a second copy of ForcePed and compare the config's ForcePed each time GetRandomPedModel gets invoked to check if it should update its list of ped hashes, which is not particularly optimal. I couldn't find any other way outside of modifying the config reading logic to include code specific to parsing ForcePed and not keeping it self-contained anymore though.

@pongo1231 pongo1231 force-pushed the forceped_multiple_models branch from 2640a4d to 4cdfe0e Compare April 12, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants