-
Notifications
You must be signed in to change notification settings - Fork 212
Add a guide page about the ParslPoolExecutor #4035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
A few other grammar/style fixes too: avoiding the 2nd-person, not repeating a word within the same paragraph.
|
|
||
| 3. *No Multiprocessing Objects*: Tools such as the :class:`multiprocessing.Queue` and | ||
| `synchronization primitives <https://docs.python.org/3/library/multiprocessing.html#synchronization-primitives>`_ | ||
| may not work in Parsl without specific configuration of the :class:`multiprocessing.Manager`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would simplify this to those objects will not work.
if you want to overlay your own self-constructed comms network using however you want, then so be it but you don't need to be tricked into thinking that's a good idea in this intro guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great point
| The core concept of workflows is that Parsl Apps produce **Futures** | ||
| with all features from those in Python's :mod:`concurrent.futures` module and more. | ||
|
|
||
| The Parsl programs must contain a ``parsl.load`` statement to start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not true, if you're passing in a config like with ParslPoolExecutor(config=config) as pool: ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. That need fixing
| workflow | ||
| exceptions | ||
| lifted_ops | ||
| logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is from your adjacent PR I think and doesn't belong here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Yea, I messed up my commits
Description
Expands the documentation about the
concurrent.futures.Executor-based interface to Parsl (ParslPoolExecutor).I've been using this more lately and had a conversation with @jan-janssen about it. So, it's probably past time we introduce it to users more clearly.
Changed Behaviour
Expands the documentation
Fixes
N/A
Type of change