Update options.html with note for macOS users#26
Open
ljuntyg wants to merge 2 commits intoPaulMorris:masterfrom
Open
Update options.html with note for macOS users#26ljuntyg wants to merge 2 commits intoPaulMorris:masterfrom
ljuntyg wants to merge 2 commits intoPaulMorris:masterfrom
Conversation
For reminders to appear for macOS users they need to allow Firefox to send notifications, this permission appears to be disabled by default on macOS and Firefox does not remind the user of this when the add-on is installed. This can cause some confusion, because Firefox will notify the user that the add-on will have (browser-level) notification permissions on installation, but Firefox will not notify the user if it does not have system permissions for notifications on macOS (as is the case by default). I updated options.html with a note about this to prevent confusion for macOS users. I think it might be possible to update options.html from options.js based on OS when the page is opened so that this note is only shown to macOS users, but this commit does not include that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reminders to appear for macOS users they need to allow Firefox to send notifications, this permission appears to be disabled by default on macOS and Firefox does not remind the user of this when the add-on is installed.
This can cause some confusion, because Firefox will notify the user that the add-on will have (browser-level) notification permissions on installation, but Firefox will not notify the user if it does not have system permissions for notifications on macOS (as is the case by default).
I updated options.html with a note about this to prevent confusion for macOS users. I think it might be possible to update options.html from options.js based on OS when the page is opened so that this note is only shown to macOS users, but this commit does not include that.
I also submitted an issue #25 which suggests possibly updating the longer add-on description with a similar note. I believe that can only be done by the add-on publisher, only the short description can be changed in manifest.json and it wouldn't be a good place for a note like that.