feat: pro setting by chedieck · Pull Request #1013 · PayButton/paybutton-server

chedieck · 2025-06-10T11:42:29Z

Related to #983

Description

Adds new config parameters (check config/example-config.json)

Adds the basics for the PayButton Pro feature.

Front-end button in /account and dedicated view to buy it using PayButton (buy backend logic NOT implemented yet)
Database, backend api to see if user is Pro and remaining time

To be implemented in subsequent PRs:

Backend buy logic
Better CSS to newly added views
Pro-exclusive features

Test plan

After adding the new parameters to paybutton-config.json, make sure the front-end is functional and good enough as a ground for the later implementation of the aforementioned features.

Klakurka

The paybutton doesn't seem to have amount + op_return set when clicking on the QR code.

Klakurka · 2025-06-10T20:44:07Z

+    <h3>PayButton Pro</h3>
+    <div className={style.pro_ctn}>
+      <span>{text}</span>
+      {isPro === false && <ProPurchase/>}
+    </div>


Somewhere in the div we should add a 'What is this?' button like we have on the Public Key section above it.

Klakurka · 2025-06-10T20:46:53Z

+const ProPurchase = (): JSX.Element => {
+  return <div className="WIP">
+  <button>
+    <Link href='/pro'>Buy Pro</Link>


Let's go with "Upgrade".

Klakurka · 2025-06-10T20:47:22Z

+
+const ProPurchase = (): JSX.Element => {
+  return <div className="WIP">
+  <button>


Somehow the "Buy Pro" button is using different styling to our other buttons (eg. "Org Create"). It should be the same.

chedieck · 2025-06-12T21:24:51Z

Addressed issues, except for

These shouldn't actually be in the readme right? These are dev values.

Should I leave them in example-config.json but take it out of the README.md default?

The paybutton doesn't seem to have amount + op_return set when clicking on the QR code.
Amount was working fine for me, but as for the OP_RETURN:

Server i using version the out-of-date 2.0.0 version of PayButton.
I'll update it to 4.1.x after PayButton/paybutton#505 is addressed, then it should work fine.

Klakurka · 2025-06-13T06:08:21Z

+      {isPro === false && <ProPurchase/>}
+      {infoModal && (
+        <div className={stylep.public_key_info_ctn}>
+          Lorem ipsum dolor sit amet, consectetur adipiscing elit. Donec tincidunt risus libero, venenatis commodo nibh commodo eget. Aenean turpis tellus, consectetur vel consequat nec, vehicula quis odio. Sed vitae venenatis orci. Vestibulum a facilisis tellus. Nunc at hendrerit


Let's display an HTML table here with what each tier offers.

| Standard | Pro Emails | 5 / day | 100 / day Addresses Per Button | 20 | Unlimited

Etc.

Addressed, for that I rewrote the config files (and updated the README accordingly). This new paradigm will let us keep adding pro features more easily.

To test it out, remember to update paybutton-config.json (use config/example-config.json as reference)

chedieck · 2025-06-20T14:09:10Z

I changed this PR to Draft because right now it contains TypeScript errors that will only be solved once PayButton/paybutton#509 is approved, merged and released.

chedieck · 2025-07-22T17:40:25Z

Error on account page:

Gotta update the paybutton-config.json, just copy the proSettings from config/example-config.json

Klakurka · 2025-07-22T18:00:28Z

Checks failing?

chedieck · 2025-07-23T11:21:41Z

Checks failing?

For some reason it was saying "Could not import X from Prisma" to everything. Couldn't understand from the changes, ran it again, worked.

Klakurka

I get some errors when I go to pay:

chedieck · 2025-07-29T11:37:44Z

I get some errors when I go to pay:

Can you paste here the proSettings property you have in your paybutton-config.json? It seems to be misconfigured.

Klakurka · 2025-07-30T06:46:23Z

I get some errors when I go to pay:

Can you paste here the proSettings property you have in your paybutton-config.json? It seems to be misconfigured.

 "proSettings": {
    "enabled": true,
    "monthsCost": {
      "1": 10,
      "3": 20,
      "6": 30,
      "12": 50
    }
  },
  "proMonthsCost": {
      "1": "0.010",
      "3": "0.020",
      "6": "0.030",
      "12": "0.050"
  },

chedieck · 2025-08-04T16:47:55Z

I get some errors when I go to pay:

Can you paste here the proSettings property you have in your paybutton-config.json? It seems to be misconfigured.
 "proSettings": {
    "enabled": true,
    "monthsCost": {
      "1": 10,
      "3": 20,
      "6": 30,
      "12": 50
    }
  },
  "proMonthsCost": {
      "1": "0.010",
      "3": "0.020",
      "6": "0.030",
      "12": "0.050"
  },

Missing some stuff. From example-config.json:

  "proSettings": {
    "enabled": true,
    "monthsCost": {
      "1": 10,
      "3": 20,
      "6": 30,
      "12": 50
    },
    "payoutAddress":  "ecash:qrf4zh4vgrdal8d8gu905d90w5u2y60djcd2d5h6un",
    "standardDailyEmailLimit": 5,
    "proDailyEmailLimit": 100,
    "standardAddressesPerButtonLimit": 20,
    "proAddressesPerButtonLimit": "Inf"
  }

also this proMonthsCost property is obsolete, everything pro related is now in proSettings.

Klakurka

Clicking the "What is this?" info button results in this:

- I still can't get payments to work:

Klakurka

OK - still had some config issues that I managed to fix.

Let's cut the "What is this?" button and just display the info all the time.

Klakurka · 2025-08-05T01:49:31Z

+type: {
+  enabled: boolean,
+  monthsCost: {
+      [key: string]: number
+  },
+  payoutAddress: string,
+  standardDailyEmailLimit: number | "Inf",
+  proDailyEmailLimit: number | "Inf",
+  standardAddressesPerButtonLimit: number | "Inf",
+  proAddressesPerButtonLimit: number | "Inf"
+}
+default: {
+    "enabled": true,
+    "monthsCost": {
+      "1": 10,
+      "3": 20,
+      "6": 30,
+      "12": 50
+    },
+    "payoutAddress":  "ecash:qrf4zh4vgrdal8d8gu905d90w5u2y60djcd2d5h6un"
+    "standardDailyEmailLimit": 5,
+    "proDailyEmailLimit": 100,
+    "standardAddressesPerButtonLimit": 20,
+    "proAddressesPerButtonLimit": "Inf"
+}


I don't think we need this in the readme.

which part? the whole setting?

Yeah at least defining actual values in the readme here where we would have to update it twice (here and where it actually matters) is just making more work for nothing.

Klakurka · 2025-08-05T02:06:03Z

+```
+> General configuration for PayButton Pro. Each parameter is described below.
+
+##### proSettings.enabled
+```
+type: boolean
+default: true
+```
+> If the Pro feature should be enabled or hidden.
+
+##### proSettings.monthsCost
+```
+type: {
+[key: string]: number
+}
+default: {
+"1": 10,
+"3": 20,
+"6": 30,
+"12": 50
+}
+```
+> The pricing model for PayButton Pro subscription — [value] USD for [key] months.
+
+##### proSettings.payoutAddress
+```
+type: string
+default: "ecash:qrf4zh4vgrdal8d8gu905d90w5u2y60djcd2d5h6un"
+```
+> The payout address for PayButton Pro subscriptions.
+
+##### proSettings.standardDailyEmailLimit
+```
+type: number | "Inf"
+default: 5
+```
+> How many emails can a standard user send daily.
+
+##### proSettings.proDailyEmailLimit
+```
+type: number | "Inf"
+default: 20
+```
+> How many emails can a PayButton Pro user send daily.
+
+##### proSettings.standardAddressesPerButtonLimit
+```
+type: number | "Inf"
+default: 5
+```
+> How many addresses can a standard Pro user add for a single button.
+
+##### proSettings.proAddressesPerButtonLimit
+```
+type: number | "Inf"
+default: "Inf"
+```
+> How many addresses can a PayButton Pro user add for a single button.
+


We don't really get any benefit out of putting this stuff into the readme as:

Defaults now need to be updated in two places (here and in the config).

Example config has all of it.

Pro pricing is TBD.

But this 1. and 2. applies to all config settings, no?

Klakurka · 2025-08-05T02:14:24Z

+      {isPro === false && <ProPurchase/>}
+      {infoModal && (
+        <div className={stylep.public_key_info_ctn}>
+          <p>PayButton Pro users get higher limits:</p>


We can drop this for now - IMO we can improve the style/layout/etc of the Standard/Pro breakdown a lot in a follow-up.

Removed the <p> tag.

Klakurka · 2025-08-05T02:18:39Z

+            </thead>
+            <tbody>
+              <tr>
+                <td>Daily Emails</td>


Change to 'Outgoing Emails On Payment'.

Klakurka · 2025-08-05T02:20:32Z

+                <td>{showLimit(config.proSettings.standardDailyEmailLimit)}</td>
+                <td>{showLimit(config.proSettings.proDailyEmailLimit)}</td>


Add "/day".

Klakurka · 2025-08-05T02:34:08Z

+              </tr>
+            </thead>
+            <tbody>
+              <tr>


Add a new line for 'Outgoing Server-to-Server Messages On Payment' (daily limit will be the same as emails).

chedieck · 2025-08-05T22:09:08Z

Let's cut the "What is this?" button and just display the info all the time.

Done.

Klakurka

We can iterate on this over time.

chedieck and others added 12 commits June 4, 2025 13:46

feat: add proUntil column

ff67f3d

feat: add config options for pro

0aba51a

refactor: organization title

01f431a

feat: component, service & endpoint to get pro status

8a50bfd

fix: mocked objects

e8ecc50

refactor: rename ProConfig -> ProDisplay

4080778

feat: show ProDisplay and ProPurchase

d8631d7

feat: pro settings skeleton

d68460f

chore: update default address

b3a35ae

feat: make link button

390c8e3

fix: type on new config parameter

24bdc53

chore: add new config parameters to README

47561ab

Klakurka self-requested a review June 10, 2025 18:17

Klakurka requested changes Jun 10, 2025

View reviewed changes

chedieck added 5 commits June 12, 2025 17:08

fix: Upgrade to Pro text & css

e1325fa

feat: add hint

a6943eb

fix: default export name

35508b1

fix: button link css

95167d6

fix latest to be 4.1.0

69f173e

Merge branch 'master' into feat/pro-setting

fcd7a4d

Klakurka requested changes Jun 13, 2025

View reviewed changes

chedieck added 3 commits June 20, 2025 10:34

refactor: update config and README

4d0d746

fix: update code to use new config

968a5b2

feat: informative table with limits

0336536

chedieck marked this pull request as draft June 20, 2025 14:06

fix: readme

8a91569

chedieck force-pushed the feat/pro-setting branch from 4e85ad0 to 8a91569 Compare June 20, 2025 17:16

chedieck marked this pull request as ready for review July 14, 2025 14:17

lissavxo and others added 9 commits July 18, 2025 15:52

fix: improve next invoice number method

8784edd

refactor: clean up

3141633

refactor: clean up

7e87d8e

feat: invoice transaction optional

8dc874e

refactor: clean up

6dd4900

feat: use prisma decimal

b7efd58

fix: button detail for 0 txs

8d385ba

fix: missing comma

63fa2a2

Merge branch 'master' into feat/pro-setting

a5db482

Klakurka requested changes Jul 26, 2025

View reviewed changes

Klakurka assigned chedieck Jul 28, 2025

Merge branch 'master' into feat/pro-setting

9a03f88

Klakurka requested changes Aug 5, 2025

View reviewed changes

chedieck added 2 commits August 5, 2025 19:07

refactor: prodisplay modal rewording

9b1e07f

refactor: display pro info all the time

a1c80d1

Klakurka added enhancement (UI/UX/feature) New feature or request sustainability Funding and revenue labels Aug 6, 2025

chedieck added 3 commits August 6, 2025 13:29

chore: remove defaults from README.md

57e8c01

chore: remove redundant type explanation

2930c90

Merge branch 'master' into feat/pro-setting

07ccc28

Klakurka approved these changes Aug 6, 2025

View reviewed changes

Klakurka merged commit d2fe47c into master Aug 6, 2025
2 checks passed

		<td>{showLimit(config.proSettings.standardDailyEmailLimit)}</td>
		<td>{showLimit(config.proSettings.proDailyEmailLimit)}</td>

Conversation

chedieck commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test plan

Uh oh!

Klakurka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chedieck commented Jun 12, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chedieck commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chedieck commented Jul 22, 2025

Uh oh!

Klakurka commented Jul 22, 2025

Uh oh!

chedieck commented Jul 23, 2025

Uh oh!

Klakurka left a comment

Choose a reason for hiding this comment

Uh oh!

chedieck commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Klakurka commented Jul 30, 2025

Uh oh!

chedieck commented Aug 4, 2025

Uh oh!

Klakurka left a comment

Choose a reason for hiding this comment

Uh oh!

Klakurka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chedieck Aug 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chedieck commented Aug 5, 2025

Uh oh!

Klakurka left a comment

chedieck commented Jun 10, 2025 •

edited

Loading

chedieck commented Jun 20, 2025 •

edited

Loading

chedieck commented Jul 29, 2025 •

edited

Loading

chedieck Aug 5, 2025 •

edited

Loading