[#300] feat: keep socket open on closed button#485
Merged
Conversation
Collaborator
5d2730e to
9f6c90a
Compare
Collaborator
|
It is not working properly, I was able to trigger the payment success behavior once but the other times I tried I can only hear the sound the dialog doesn't open |
lissavxo
previously approved these changes
May 15, 2025
Klakurka
requested changes
May 15, 2025
Member
Klakurka
left a comment
There was a problem hiding this comment.
We need to make a decision around how to handle the user clicking multiple buttons on the page before paying.
If I open one button dialog, close it, then open a 2nd different one and pay to that, the first one will open up on top of my active button dialog.
One option is to only ever keep the last connection open. If somebody opens a new dialog, kill the old one.
Another option is to continue having it work as-is but if I pay to button #2, don't trigger #1 to open in my face.
Either option is good with me.
Klakurka
previously approved these changes
May 26, 2025
Member
|
Conflicts. |
Klakurka
approved these changes
May 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related to #300
Description
Changes the logic in order to make the
onSuccessfunction still fire for a closed PayButton, as long as it has been opened once since page load.Test plan
Make sure not only #300 is working well, but also sideshift altpayments & Widgets, since the changes also affect them.