Feat/disable sound prop#487
Merged
Merged
Conversation
chedieck
requested changes
Apr 22, 2025
| const shiftStatus = await paymentClient.getPaymentStatus(altpaymentShift.id) | ||
| if (shiftStatus.status === 'settled') { | ||
| if (sound) txSound.play().catch(() => {}); | ||
| if (sound && disableSound !== true) txSound.play().catch(() => {}); |
Collaborator
There was a problem hiding this comment.
shouldn't this be !isPropsTrue(disableSound) too?
lissavxo
force-pushed
the
feat/disable-sound-prop
branch
from
90efb47 to
6de0dea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #465
Description
Added a new prop to disable on success sound
Test plan
Test if the sound is disabled when using the new prop on success scenario