UI: Reflect column and engine values for existing tables #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serprex
reviewed
Jan 14, 2025
| @@ -199,12 +199,17 @@ export default function SchemaBox({ | |||
| ?.map((tableMap) => tableMap.sourceTableIdentifier) | |||
| .includes(row.source) | |||
| ) { | |||
| const existingRow = alreadySelectedTables?.find( | |||
There was a problem hiding this comment.
Suggested change
| const existingRow = alreadySelectedTables?.find( | |
| const existingRow = alreadySelectedTables.find( |
can remove the ?.map above too. As is it'll hit an error about trying to call undefined as a function. You'd have to use the find?.(...) to null check the call too. Tho, in this case, we only end up here if map includes returned true, so if alreadySelectedTables was null/undefined you'd never run this code in that case
This might be related to earlier PR preferring sending empty arrays over null
serprex
reviewed
Jan 14, 2025
Comment on lines
+210
to
+212
| alreadySelectedTables?.find( | ||
| (tableMap) => tableMap.sourceTableIdentifier === row.source | ||
| )?.destinationTableIdentifier ?? ''; |
There was a problem hiding this comment.
Suggested change
| alreadySelectedTables?.find( | |
| (tableMap) => tableMap.sourceTableIdentifier === row.source | |
| )?.destinationTableIdentifier ?? ''; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, excluded columns and engine selection are not populated in the table box for an existing table in the mirror (where the destination field, engine, columns are disabled)
This PR wires those through. Tested