Unwrap Qi, interval conversions, custom RPC by jdowning100 · Pull Request #471 · PelagusWallet/pelagus-extension

jdowning100 · 2025-08-20T23:00:33Z

No description provided.

Copilot

Pull Request Overview

This PR introduces several key features to enhance the wallet's conversion and customization capabilities. The main purpose is to add unwrapping functionality for WQI tokens, interval-based conversions for automated trading, and custom RPC configuration for improved network flexibility.

Key changes:

Added WQI unwrapping functionality allowing users to convert wrapped tokens back to native Qi
Implemented interval conversions enabling automated periodic conversions with configurable timing and transaction counts
Added custom RPC URL configuration for network customization
Updated package dependencies to quais ^1.0.0-alpha.52

Reviewed Changes

Copilot reviewed 26 out of 27 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
ui/routes/routes.tsx	Added new routes for interval conversions, unwrap functionality, and error handling
ui/pages/_NewDesign/WrapPage.tsx	Enhanced to support both wrap and unwrap operations with conditional UI logic
ui/pages/_NewDesign/RunningIntervals.tsx	New page for displaying and managing interval conversions
ui/pages/_NewDesign/IntervalErrorDetails.tsx	New page for displaying detailed error information for failed intervals
ui/pages/_NewDesign/ConvertPage.tsx	Updated to handle interval conversion navigation
ui/pages/_NewDesign/ConvertIntervalConfirmation.tsx	New confirmation page for interval conversion setup
ui/pages/_NewDesign/ConfirmWrapPage.tsx	Enhanced to support unwrap confirmation flow
ui/pages/_NewDesign/ConfirmConversionPage.tsx	Improved error handling for conversion failures
ui/pages/SingleAsset.tsx	Added unwrap button for WQI tokens
ui/pages/Settings.tsx	Added custom RPC and interval management options
background/services/transactions/index.ts	Added interval conversion logic and unwrap functionality
background/services/transactions/db.ts	Added database schema for interval conversions
background/redux-slices/convertAssets.ts	Added interval settings and unwrap actions
background/redux-slices/networks.ts	Added custom RPC management

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-20T23:02:48Z

  const history = useHistory()
  const dispatch = useBackgroundDispatch()
  const location = useLocation<WrapLocationState>()
+  const isUnwrap = location.pathname === "/unwrap"


[nitpick] Consider using a more explicit parameter or state-based approach instead of relying on pathname comparison. This makes the component's behavior more predictable and easier to test.

Suggested change

const isUnwrap = location.pathname === "/unwrap"

const isUnwrap = location.state?.isUnwrap ?? false

Copilot · 2025-08-20T23:02:49Z

+            </div>
+            <div className="info-box">
+              <p style={{ fontWeight: "bold" }}>Note: Qi will be locked for two weeks. Only whole numbers of WQI can be unwrapped. Fractional amounts are not supported.</p>
+            </div>


Avoid inline styles. Define the font-weight styling in the CSS block below for consistency with the rest of the component.

Copilot · 2025-08-20T23:02:49Z

+
+  const loadIntervals = async () => {
+    try {
+      const result = await dispatch(getIntervalConversionsHandle()) as any


Avoid using 'as any' type assertion. Define proper types for the dispatch result to maintain type safety.

Suggested change

const result = await dispatch(getIntervalConversionsHandle()) as any

// The result can be either an array of IntervalConversion or an object with a payload property containing such an array

type IntervalConversionsDispatchResult = IntervalConversion[] | { payload: IntervalConversion[] }

const loadIntervals = async () => {

try {

const result: IntervalConversionsDispatchResult = await dispatch(getIntervalConversionsHandle())

Copilot · 2025-08-20T23:02:49Z

+        // Result is the interval directly
+        console.log(`[IntervalErrorDetails] Found interval directly in result:`, result)
+        intervalData = result
+      } else if (result?.payload) {


Avoid using 'as any' type assertion. Define proper types for the dispatch result to maintain type safety.

Suggested change

} else if (result?.payload) {

const result: IntervalConversionResult = await dispatch(getIntervalConversionHandle(intervalId))

console.log(`[IntervalErrorDetails] Result from dispatch:`, result)

// Check if result is the interval directly or wrapped in payload

let intervalData: IntervalConversion | null = null

if ("id" in result) {

// Result is the interval directly

console.log(`[IntervalErrorDetails] Found interval directly in result:`, result)

intervalData = result

} else if ("payload" in result && result.payload) {

Copilot · 2025-08-20T23:02:50Z

+    setError(null)
+
+    try {
+      const result = await dispatch(startIntervalConversionHandle()) as any


Avoid using 'as any' type assertion. Define proper types for the dispatch result to maintain type safety.

Suggested change

const result = await dispatch(startIntervalConversionHandle()) as any

const result: { payload?: { error?: string } } = await dispatch(startIntervalConversionHandle())

Copilot · 2025-08-20T23:02:50Z

+      const maxAttempts = 2000
      let attempts = 0

      while (attempts < maxAttempts) {


[nitpick] This is a significant increase from 200 to 2000 attempts. Consider making this configurable or documenting why such a high number of attempts is necessary.

Suggested change

while (attempts < maxAttempts) {

let attempts = 0

while (attempts < MAX_UNUSED_QI_ADDRESS_ATTEMPTS) {

Copilot · 2025-08-20T23:02:51Z

+          // Converting Quai to Qi
+          await this.convertQuaiToQi(params.from.address, params.amount, params.maxSlippage)
+          // TODO: Get transaction hash from conversion
+          txHash = `tx_${Date.now()}`


Using placeholder transaction hashes instead of actual transaction hashes from conversion functions will cause incorrect transaction tracking. The TODO comments indicate this is incomplete implementation.

Suggested change

txHash = `tx_${Date.now()}`

const qiToQuaiTxHash = await this.convertQiToQuai(params.to.address, params.amount, params.maxSlippage)

txHash = qiToQuaiTxHash

} else if (!isFromUtxo && isToUtxo) {

// Converting Quai to Qi

const quaiToQiTxHash = await this.convertQuaiToQi(params.from.address, params.amount, params.maxSlippage)

txHash = quaiToQiTxHash

Copilot · 2025-08-20T23:02:51Z

+          // Converting Quai to Qi
+          await this.convertQuaiToQi(params.from.address, params.amount, params.maxSlippage)
+          // TODO: Get transaction hash from conversion
+          txHash = `tx_${Date.now()}`


Using placeholder transaction hashes instead of actual transaction hashes from conversion functions will cause incorrect transaction tracking. The TODO comments indicate this is incomplete implementation.

Suggested change

txHash = `tx_${Date.now()}`

const txResponse = await this.convertQiToQuai(params.to.address, params.amount, params.maxSlippage)

txHash = txResponse?.hash

} else if (!isFromUtxo && isToUtxo) {

// Converting Quai to Qi

const txResponse = await this.convertQuaiToQi(params.from.address, params.amount, params.maxSlippage)

txHash = txResponse?.hash

Copilot · 2025-08-20T23:02:51Z

    )
    this.initializeProviders(testNetworks)
-    this.startLocalNodeCheckingInterval()
+    // Don't automatically start local node checking - only when local network is actually selected


[nitpick] This behavior change should be documented more thoroughly. The comment explains what changed but not why this optimization was necessary.

Suggested change

// Don't automatically start local node checking - only when local network is actually selected

// Don't automatically start local node checking.

// Rationale: Starting local node checking only when the local network is actually selected avoids unnecessary resource usage and network requests.

// This optimization prevents redundant polling and potential side effects when the local node is not relevant to the user's current network selection.

Copilot · 2025-08-20T23:02:52Z

              className="custom-slippage-input"
              placeholder="Custom"
-              value={isCustom ? customValue : ""}
+              value={isCustom ? customValue : (!isPresetValue ? getPercentageValue() : "")}


[nitpick] This complex ternary logic is difficult to read. Consider extracting this into a separate function with a descriptive name for better readability.

Suggested change

value={isCustom ? customValue : (!isPresetValue ? getPercentageValue() : "")}

value={getInputValue()}

jdowning100 added 2 commits August 7, 2025 23:14

Add interval conversions feature

099b623

Added ability to add custom RPC URLs in settings

5d4fb0a

Copilot AI review requested due to automatic review settings August 20, 2025 23:00

Copilot AI reviewed Aug 20, 2025

View reviewed changes

Unwrapping WQI and bugfixes

2499c77

jdowning100 force-pushed the updates branch from 80b4b1e to 2499c77 Compare September 8, 2025 19:23

Navigation Menu

Uh oh!

Unwrap Qi, interval conversions, custom RPC - #471

Unwrap Qi, interval conversions, custom RPC#471
jdowning100 wants to merge 3 commits into
PelagusWallet:1.0from
jdowning100:updates

jdowning100 commented Aug 20, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Copilot AI Aug 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	const isUnwrap = location.pathname === "/unwrap"
	const isUnwrap = location.state?.isUnwrap ?? false

-      const result = await dispatch(getIntervalConversionsHandle()) as any
+  // The result can be either an array of IntervalConversion or an object with a payload property containing such an array
+  type IntervalConversionsDispatchResult = IntervalConversion[] | { payload: IntervalConversion[] }
+  const loadIntervals = async () => {
+    try {
+      const result: IntervalConversionsDispatchResult = await dispatch(getIntervalConversionsHandle())

-      } else if (result?.payload) {
+      const result: IntervalConversionResult = await dispatch(getIntervalConversionHandle(intervalId))
+      console.log(`[IntervalErrorDetails] Result from dispatch:`, result)
+      // Check if result is the interval directly or wrapped in payload
+      let intervalData: IntervalConversion | null = null
+      if ("id" in result) {
+        // Result is the interval directly
+        console.log(`[IntervalErrorDetails] Found interval directly in result:`, result)
+        intervalData = result
+      } else if ("payload" in result && result.payload) {

	const result = await dispatch(startIntervalConversionHandle()) as any
	const result: { payload?: { error?: string } } = await dispatch(startIntervalConversionHandle())

-          txHash = `tx_${Date.now()}`
+          const qiToQuaiTxHash = await this.convertQiToQuai(params.to.address, params.amount, params.maxSlippage)
+          txHash = qiToQuaiTxHash
+        } else if (!isFromUtxo && isToUtxo) {
+          // Converting Quai to Qi
+          const quaiToQiTxHash = await this.convertQuaiToQi(params.from.address, params.amount, params.maxSlippage)
+          txHash = quaiToQiTxHash

-          txHash = `tx_${Date.now()}`
+          const txResponse = await this.convertQiToQuai(params.to.address, params.amount, params.maxSlippage)
+          txHash = txResponse?.hash
+        } else if (!isFromUtxo && isToUtxo) {
+          // Converting Quai to Qi
+          const txResponse = await this.convertQuaiToQi(params.from.address, params.amount, params.maxSlippage)
+          txHash = txResponse?.hash

-    // Don't automatically start local node checking - only when local network is actually selected
+    // Don't automatically start local node checking.
+    // Rationale: Starting local node checking only when the local network is actually selected avoids unnecessary resource usage and network requests.
+    // This optimization prevents redundant polling and potential side effects when the local node is not relevant to the user's current network selection.

	value={isCustom ? customValue : (!isPresetValue ? getPercentageValue() : "")}
	value={getInputValue()}

Uh oh!

Conversation

jdowning100 commented Aug 20, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants