Add POSC bypass filter for monitoring paths#3297
Merged
Merged
Conversation
Replace all scattered "/pelican/monitoring" string literals with the existing server_utils.MonitoringBaseNs constant so the monitoring base path is defined in exactly one place.
The POSC (Persist on Successful Close) plugin uses rename(2) to atomically move files from a staging directory to their final location. This fails when the source and destination are on different filesystems, which is the case for monitoring paths in Kubernetes deployments where the Origin's run location is on a separate PVC from the storage exports.
jhiemstrawisc
added
bug
Member
Author
|
Okay, the upstream changes are all ready/merged. |
h2zh
approved these changes
Apr 1, 2026
h2zh
left a comment
h2zh
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now we're going to bypass the POSC plugin for monitoring paths. I took a small detour to clean up some hard-coded monitoring path strings in favor of the monitoring base namespace variable.
Note that this should NOT be merged until both this PR is merged, and av0.6.6of the repo is released (version updates currently staged in this PR)