-
Notifications
You must be signed in to change notification settings - Fork 206
[WIP] DMET Demo #1330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[WIP] DMET Demo #1330
Conversation
👋 Hey, looks like you've updated some demos! 🐘 Don't forget to update the Please hide this comment once the field(s) are updated. Thanks! |
# then able to project the full Hamiltonian to the space of impurity and bath states, known as embedding space. | ||
# .. math:: | ||
# | ||
# \hat{H}^{imp} = \hat{P} \hat{H}^{sys}\hat{P} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please define P.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a projection operator, added that. Full definition of this operator will require more equations. If just saying that it is a projection operator doesn't seem enough we can also remove this equation to keep things simple.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it as simple as P = |ij><ij|
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but then we need to define what ij are, or is it okay to leave that to the user?
solver=solver_info[0], solver_args=solver_info[1], labels=lo_labels) | ||
return rhoImp, EnergyImp | ||
|
||
# We must note here that the effect of environment included in the previous step is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explicitly mention that it was single-shot. Maybe here you can call the function and compute something such as single-shot energy, so we can compare latter with the self-consistent result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It already computes the single-shot energy, as that will be the energy from 1st iteration. For such a small system, the difference between single-shot and self-consistent is not that significant.
Co-authored-by: Soran Jahangiri <[email protected]>
Co-authored-by: Soran Jahangiri <[email protected]>
Co-authored-by: Soran Jahangiri <[email protected]>
Co-authored-by: Soran Jahangiri <[email protected]>
Before submitting
Please complete the following checklist when submitting a PR:
Ensure that your tutorial executes correctly, and conforms to the
guidelines specified in the README.
Remember to do a grammar check of the content you include.
All tutorials conform to
PEP8 standards.
To auto format files, simply
pip install black
, and thenrun
black -l 100 path/to/file.py
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Title:
Density Matrix Embedding Theory (DMET) Demo
Summary:
This demo outlines the basics of density matrix embedding theory, and provides instructions on how to execute the method.
Relevant references:
Possible Drawbacks:
Related GitHub Issues:
If you are writing a demonstration, please answer these questions to facilitate the marketing process.
GOALS — Why are we working on this now?
Eg. Promote a new PL feature or show a PL implementation of a recent paper.
AUDIENCE — Who is this for?
Eg. Chemistry researchers, PL educators, beginners in quantum computing.
KEYWORDS — What words should be included in the marketing post?
Which of the following types of documentation is most similar to your file?
(more details here)