Improve LDAP dc-list flag

[termanix]

---

name: Improved the dc-list.
about: In the previous code, it was working based on /etc/hosts and it would fail sometimes cause of that.
title: 'Improve LDAP dc-list flag'
labels: 'Enhancement, bug-fix'
assignees: ''

---

Description

It was working base on /etc/hosts and tried to socket connection. It fails sometimes, espcially real life scenarios.
The functionality of the code was changed with direct DNS records and queries. It now works without being linked to /etc/hosts.
Note: It takes DNS nameserver IP address from self.host

And also used parse_result_attributes for parsing (#471)

Type of change

Please delete options that are not relevant.
[+ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

NetExec ldap $IP -u username -p password --dc-list

Screenshots (if appropriate):

[NeffIsBack]

The connection object has a built-in dns resolver:

NetExec/nxc/connection.py

Lines 180 to 191 in 72fee6a

	def resolver(self, target):
	try:
	return get_host_addr_info(
	target=target,
	force_ipv6=self.args.force_ipv6,
	dns_server=self.args.dns_server,
	dns_tcp=self.args.dns_tcp,
	dns_timeout=self.args.dns_timeout
	)
	except Exception as e:
	self.logger.info(f"Error resolving hostname {target}: {e}")
	return None

This should probably be used, as this also respects the "new" dns flags

[mpgn]

ok ✅

[NeffIsBack]

We already have dns args and imo these should be used here as well. So either the dns resolver should be the same as in the connection.py or the dns arguments should also be respected in this function

[NeffIsBack]

Refering to:

NetExec/nxc/cli.py

Lines 43 to 47 in 131e29e

	dns_group = dns_parser.add_argument_group("DNS")
	dns_group.add_argument("-6", dest="force_ipv6", action="store_true", help="Enable force IPv6")
	dns_group.add_argument("--dns-server", action="store", help="Specify DNS server (default: Use hosts file & System DNS)")
	dns_group.add_argument("--dns-tcp", action="store_true", help="Use TCP instead of UDP for DNS queries")
	dns_group.add_argument("--dns-timeout", action="store", type=int, default=3, help="DNS query timeout in seconds")

[NeffIsBack]

LGTM: