Skip to content

[TEMP FIX] Breach Mining Infinite loop crash#655

Open
Ossa88 wants to merge 1 commit into
PentestSS13:masterfrom
Ossa88:ore_loop
Open

[TEMP FIX] Breach Mining Infinite loop crash#655
Ossa88 wants to merge 1 commit into
PentestSS13:masterfrom
Ossa88:ore_loop

Conversation

@Ossa88
Copy link
Copy Markdown
Collaborator

@Ossa88 Ossa88 commented Apr 9, 2026

About The Pull Request

The breach mining pick_tile system had a potential to crash the server if it could not locate a valid location to spawn a breach.

This is a temp fix to prevent the infinite loop.

A perm solution will involve redesigning the breach systems selection process.

Why It's Good For The Game

Cheesing the breach mining can potentially crash the server. This fixes that for now.

Changelog

🆑
fix: Fixes Breach Mining crash
/:cl:

@Ossa88 Ossa88 requested a review from Constellado as a code owner April 9, 2026 21:17
@Ossa88 Ossa88 added the TM Candidate This PR is approved for TM label Apr 10, 2026
@github-actions
Copy link
Copy Markdown
Contributor

This PR has been inactive for a month. This means it is at risk of being auto closed in a week, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions Bot added the Stale label May 19, 2026
@Ossa88 Ossa88 removed the Stale label May 21, 2026
@Ossa88
Copy link
Copy Markdown
Collaborator Author

Ossa88 commented May 23, 2026

Going to keep this as a Temp Fix TM for now, I plan on reworking the breach mining entirely to allow some wall destruction and other such things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code Change TM Candidate This PR is approved for TM

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant