Add onPressedButNotHeld callback to usePressHoldRelease hook #62
+3,112
−5,918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ngenovese11 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: ngenovese11 <[email protected]>
Co-authored-by: ngenovese11 <[email protected]>
Copilot
AI
changed the title
Copilot finished work on behalf of
ngenovese11
September 15, 2025 15:20
|
an empty commit needs to be added with the "feat:" prefix to trigger a build via semantic release @copilot |
This feature enables distinct handling of short presses versus holds in the usePressHoldRelease hook.
Copilot finished work on behalf of
ngenovese11
September 15, 2025 15:29
|
🎉 This PR is included in version 1.21.0-copilot-fix-61.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.21.0-merge-press-and-hold-hook.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onPressedButNotHeldparameter to thePressHoldReleaseParamsinterfaceheldref to track whether the button was actually held during the interactiononPointerDownto reset theheldstate and set it totruewhen the hold timer firesonPointerUpto check theheldstate and conditionally callonPressedButNotHeldfor short pressesThe hook now distinguishes between:
onPress→onRelease→onPressedButNotHeldonPress→onHold→onRelease(noonPressedButNotHeld)All existing behavior for
onPress,onRelease, andonHoldremains unchanged.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.